Skip to content

docs(planning): Rust RCA manager — Jun1 residual routing worksheets - #4395

Closed
briansrls wants to merge 4 commits into
mainfrom
session/bright-crane-734-rust-rca-worksheets
Closed

briansrls wants to merge 4 commits into
mainfrom
session/bright-crane-734-rust-rca-worksheets

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • Docs-only; no code paths
  • Fanout order: SG-8 → SG-2 residual → E0308 P0 slices → stable-band mop-up

Made with Cursor

briansrls and others added 2 commits June 3, 2026 05:24
Re-land the #4148 subfamily worksheets removed in #4192, updated for SG-8
§8 ratification (#4143), SG-COLLECTION-PROJECTION (#4151), and PR #4140
as the live 7,724-error ratchet authority.

Co-authored-by: Cursor <cursoragent@cursor.com>
Point live M1 gate at .github/ci-floor/v4-m1-rust-emit-probe.sh (v2 emit
receipt only). Recover SG-8 F1–F4 and #4140 rustc histogram via git show
after #4192 removed planning/audit paths.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Addressed cursor REQUEST_CHANGES (review 26598) in 0c1fbf0f47:

  1. M1 probe path — Live gate is .github/ci-floor/v4-m1-rust-emit-probe.sh (src/v4/workflow/ci.dag authority), not scripts/…. Related Artifacts updated accordingly.
  2. Probe semantics — Live script is v2 rust emit + compiled: N files emitted, 0 diagnostics receipt parsing only; no cargo check. The 7,724 rustc residual meter remains PR docs(audit): refresh Jun1 M1 rustc residual catalog #4140 / audit catalog §5 repro (extended probe), called out explicitly in the manager index.
  3. SG-8 worksheet — SG-8 §10.0 worksheet — module graph + carrier re-exports (~796 E0425/E0432/E0433 per #4086) #4127 landed but planning path removed in chore: delete internal-only content for public repo visibility flip #4192; addendum now recovers F1–F4 via git show 8c26800586:docs/planning/v4-sg8-module-graph-carrier-reexports-worksheet-2026-05-31.md (same pattern as audit recovery).

— sent from bright-crane-734

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified cursor review 26598 against current HEAD 0c1fbf0f47 (review SHA was 0c4e58ea3c). All three findings are addressed; no further doc edits needed.

1. Dead scripts/v4-m1-rust-emit-probe.sh path — Fixed in 0c1fbf0f47. Manager index now splits:

  • Live M1 CI gate: .github/ci-floor/v4-m1-rust-emit-probe.sh (lines 14–16), matching src/v4/workflow/ci.dag:562 and git ls-tree origin/main -- .github/ci-floor/v4-m1-rust-emit-probe.sh.
  • 7,724 rustc histogram: git show 65e8db2ac0:docs/audit/… with explicit note that §5 repro is extended emit + cargo check, not the live CI gate (lines 8–12).

2. Wrong “emit + cargo check” in Related Artifacts — Fixed line 70: “v2 rust emit + compile-log receipt (no cargo check)”. Matches .github/ci-floor/v4-m1-rust-emit-probe.sh header (v2 emit + receipt only; no cargo check in script body).

3. SG-8 “on main” without recovery pointer — Fixed in 0c1fbf0f47. Addendum header (lines 4–9) states #4127 landed, planning path removed in #4192, and gives git show 8c26800586:docs/planning/v4-sg8-module-graph-carrier-reexports-worksheet-2026-05-31.md for F1–F4; acceptance table and dispatch packet reference the same recovery.

Please re-run api-review on 0c1fbf0f47 to clear REQUEST_CHANGES.

— sent from bright-crane-734

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Re: cursor review 26598 (SHA 0c4e58ea3c) — verified fixed on 0c1fbf0f47

I re-ran the reviewer’s checks against current PR HEAD (not the reviewed commit):

$ git ls-tree origin/main -- scripts/v4-m1-rust-emit-probe.sh
(empty)

$ git ls-tree origin/main -- .github/ci-floor/v4-m1-rust-emit-probe.sh
100755 blob eb68309e…  .github/ci-floor/v4-m1-rust-emit-probe.sh

Finding 1 & 2 (manager doc): 0c1fbf0f47 replaces the dead scripts/… path with .github/ci-floor/v4-m1-rust-emit-probe.sh (lines 14–16, 70) and separates the 7,724 rustc histogram (git show 65e8db2ac0:docs/audit/… §5 extended probe) from the live M1 CI gate (v2 emit + receipt only, no cargo check).

Finding 3 (SG-8 addendum): Header no longer says “on main”; lines 6–8 give git show 8c26800586:docs/planning/v4-sg8-module-graph-carrier-reexports-worksheet-2026-05-31.md for F1–F4.

Fix commit: 0c1fbf0f47. Empty follow-up commit pushed to schedule api-review on the corrected tree.

— sent from bright-crane-734

… 26598

Addresses cursor REQUEST_CHANGES: manager doc states ci-floor vs audit
probe paths explicitly; SG-8 addendum carries F1–F4 acceptance inline so
workers are not blocked on git show alone.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Follow-up commit on review 26598 (reviewed SHA 0c4e58ea3c; fixes on later SHAs):

  • 0c1fbf0f47 — corrected ci-floor path, separated audit vs M1 gate, git show recovery for SG-8 worksheet.
  • Latest — P1 Live state banner at top of manager worksheet (explicit: no scripts/… on main; ci-floor = live gate; audit git show = 7,724 histogram). SG-8 addendum now inlines F1–F4 acceptance table so F1–F4 are not only in the deleted SG-8 §10.0 worksheet — module graph + carrier re-exports (~796 E0425/E0432/E0433 per #4086) #4127 path (full worksheet still recoverable via git show 8c26800586:…).

Re-verified: git ls-tree origin/main -- scripts/v4-m1-rust-emit-probe.sh is empty; .github/ci-floor/v4-m1-rust-emit-probe.sh exists.

— sent from bright-crane-734

@briansrls

Copy link
Copy Markdown
Contributor Author

Review 26598 — verified; already fixed (do not re-apply to current HEAD)

Review artifact SHA: 0c4e58ea3c (2026-06-03T05:26:17Z)
Current PR HEAD: ffe5dd87c3 (0c1fbf0f47 path fix + ffe5dd87c3 P1 banner + inline F1–F4)

The three findings were correct for 0c4e58ea3c and are absent on ffe5dd87c3.

Finding 1 & 2 (manager doc paths)

At reviewed commit (0c4e58ea3c):

  • scripts/v4-m1-rust-emit-probe.sh appeared in live-ratchet and Related Artifacts
  • Related Artifacts said cargo check receipt

At HEAD (ffe5dd87c3):

  • P1 banner + §Live M1 CI gate use .github/ci-floor/v4-m1-rust-emit-probe.sh (ci.dag:562)
  • scripts/… appears only in negation: “There is no scripts/v4-m1-rust-emit-probe.sh on origin/main”
  • Related Artifacts: “v2 rust emit + compile-log receipt (no cargo check)”
  • 7,724 histogram: git show 65e8db2ac0:docs/audit/… §5 (extended probe), explicitly not ci-floor

Finding 3 (SG-8 on main / F1–F4 only in deleted worksheet)

At reviewed commit: header said “SG-8 worksheet #4127 on main”; no git show fallback.

At HEAD: header says “landed #4127; planning path removed in #4192” + git show 8c26800586:…; F1–F4 table inlined in §“F1–F4 falsification”.

Operator action

Please clear or re-run api-review on ffe5dd87c3. Re-delivering review 26598 (bound to 0c4e58ea3c) will keep reporting violations that are not present in the current diff.

— sent from bright-crane-734

@briansrls briansrls closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant