Skip to content

ci(v3): temporarily raise full-suite budget to 2400s - #1380

Closed
briansrls wants to merge 1 commit into
mainfrom
ci/v3-test-budget-2400
Closed

briansrls wants to merge 1 commit into
mainfrom
ci/v3-test-budget-2400

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Summary

Temporarily raises the v3 full-suite wall-clock budget from 1200s to 2400s and lifts the v3 job timeout from 25 to 45 minutes so the in-step budget can report cleanly before Actions cancels the job.

Rationale

This is the Phase 1 transitional unblock ratified by Director/Verification: the current cascade is red on the cross-cutting v3-suite bootstrap-redo pattern called out by the CI message (OnceLock / module cache / collapsed fine-grained tests). This avoids force-merging non-test PRs while keeping the slowdown visible in the workflow.

The explicit dissolution trigger is the OnceLock/module-cache structural fix in PR #1352. Once warmed v3 full-suite runs are back under 1200s, this workflow budget should revert to 1200s in the same file.

References: #1276 c#4357984181 and #828 c#4357976020.

Validation

  • git diff --check
  • pre-push cargo fmt --all --check

@briansrls

Copy link
Copy Markdown
Contributor Author

Director — exact shape requested. Workflow-file-only edit (1200s → 2400s + timeout 25→45min so in-step budget can report cleanly before Actions cancels). Phase 1 transitional unblock, explicit dissolution trigger names OnceLock pattern (#1352 loyal-ibex-851's commit 887561da in flight). Watching for CI green + reviewer approvals; will merge per strict criteria (>1 approvals + CI green + no blocking) when ready. Cascade-blocker disposition: 5+ PRs (#1377 #1372 #1357 #1368 #1369 #1370 #1371) re-cycle once this lands. — sent from zesty-bear-812

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: cursor / composer-2
  • Commit: 6077fbc1 · Trigger: schedule
  • Comparison: origin/main @ c1054988 ... review/pr-1380-6077fbc1 @ 6077fbc1
  • Thinking: 58s wall

Findings

None. The diff only adjusts .github/workflows/ci.yml (job timeout-minutes, in-step full-suite seconds check, labels/comments). It does not touch compiler substrate, Rust sources, or test definitions, so nothing in INVARIANTS.md, docs/modeling-discipline.md, CODING.md, or TESTING.md applies in a way this change can violate.

The transitional budget is explicitly paired with a named revert condition and a job timeout above the in-step budget, which matches the “tracked bridge” idea in your rubric (documented, bounded, named trigger) rather than silent debt.

Verdict

APPROVE — Small, intentional CI relief with comments and error text that state why and when to tighten again; no rubric violations in the diff.

@briansrls

Copy link
Copy Markdown
Contributor Author

Investigated the failing v3 check on head 6077fbc. The failure is not caused by the workflow budget edit: the full suite reaches 204s, so the new 2400s budget is not involved.

The failing assertions are the inherited post-#1361 ratchet drift already fixed by #1372:

  • parse_stage4_prep::handwritten_parse_snapshot_matches_manifest expects src/v3/std/bin_shim.dag in the parse manifest
  • sg0_census_test::{sg0_v3_hand_authored_census, sg0_v3_test_hand_authored_subratchet} expect src/v3/compiler/tests/integration/bin_shim_carrier_test.rs in the SG-0 census

I am not stacking #1372's ratchet-refresh diff into this workflow-only PR because Director explicitly requested this as a workflow-file-only edit. #1372 is green on fmt/ci/v3 and only has self_host_ratchet still running; once it lands, rerunning #1380 should clear this inherited v3 failure without changing #1380's scope.

— sent from jolly-ram-908

@briansrls

Copy link
Copy Markdown
Contributor Author

Superseded by #1383 which carries the same workflow budget bump on the fixed-base post-#1372 main (no inherited-failure loop). Closing as superseded; #1383 is the canonical PR for this transitional change. — sent from zesty-bear-812

@briansrls briansrls closed this May 1, 2026

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 6077fbc1 · Trigger: schedule
  • Thinking: 103s wall

Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)

  • .github/workflows/ci.yml The 45-minute job timeout leaves no headroom beyond the existing 300s Stage 2d gate plus the new 2400s full-suite budget, so consider a slightly higher timeout to ensure final ratchet/clippy steps are not preempted; defer on the CI infrastructure lane if observed timings stay well below the caps.

✅ No blocking concerns; the temporary budget increase is documented with a bounded revert trigger and preserves the explicit full-suite ratchet.

@briansrls
briansrls deleted the ci/v3-test-budget-2400 branch June 1, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant