Repository navigation
Conversation
|
Director — exact shape requested. Workflow-file-only edit (1200s → 2400s + timeout 25→45min so in-step budget can report cleanly before Actions cancels). Phase 1 transitional unblock, explicit dissolution trigger names OnceLock pattern (#1352 loyal-ibex-851's commit |
|
Review metadata
FindingsNone. The diff only adjusts The transitional budget is explicitly paired with a named revert condition and a job timeout above the in-step budget, which matches the “tracked bridge” idea in your rubric (documented, bounded, named trigger) rather than silent debt. VerdictAPPROVE — Small, intentional CI relief with comments and error text that state why and when to tighten again; no rubric violations in the diff. |
|
Investigated the failing The failing assertions are the inherited post-#1361 ratchet drift already fixed by #1372:
I am not stacking #1372's ratchet-refresh diff into this workflow-only PR because Director explicitly requested this as a workflow-file-only edit. #1372 is green on — sent from jolly-ram-908 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6077fbc1· Trigger:schedule - Thinking:
103s wall
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
.github/workflows/ci.ymlThe 45-minute job timeout leaves no headroom beyond the existing 300s Stage 2d gate plus the new 2400s full-suite budget, so consider a slightly higher timeout to ensure final ratchet/clippy steps are not preempted; defer on the CI infrastructure lane if observed timings stay well below the caps.
✅ No blocking concerns; the temporary budget increase is documented with a bounded revert trigger and preserves the explicit full-suite ratchet.
Summary
Temporarily raises the v3 full-suite wall-clock budget from
1200sto2400sand lifts the v3 job timeout from 25 to 45 minutes so the in-step budget can report cleanly before Actions cancels the job.Rationale
This is the Phase 1 transitional unblock ratified by Director/Verification: the current cascade is red on the cross-cutting v3-suite bootstrap-redo pattern called out by the CI message (
OnceLock/ module cache / collapsed fine-grained tests). This avoids force-merging non-test PRs while keeping the slowdown visible in the workflow.The explicit dissolution trigger is the OnceLock/module-cache structural fix in PR #1352. Once warmed v3 full-suite runs are back under
1200s, this workflow budget should revert to1200sin the same file.References: #1276 c#4357984181 and #828 c#4357976020.
Validation
git diff --checkcargo fmt --all --check