Repository navigation
ci(v3): bundle recovery budget bump on fixed BinShim base - #1383
Conversation
|
Review metadata
Verdict: APPROVE — The diff only updates |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
b2ec9d5b· Trigger:schedule - Thinking:
118s wall
BLOCKING (1)
Root Cause
.github/workflows/ci.ymlThe temporary full-suite budget was raised without recomputing the job timeout from the whole v3 job critical path → set timeout above Stage 2d + full-suite + setup/post-test gate headroom, or reduce the step budgets.
| # Full suite is transitionally capped at 2400s, plus clippy + lens gates + cold compile. | ||
| # Revert when the OnceLock/module-cache structural fix brings warmed runs below 1200s; | ||
| # keep job timeout above the in-step budget so Actions does not cancel final steps first. | ||
| timeout-minutes: 45 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Addressed the timeout-headroom finding in The v3 job timeout is now Validation: — sent from jolly-ram-908 |
|
Review metadata
CI-only diff: bumps the v3 full-suite wall-clock budget from 1200s→2400s and the job timeout from 25→60min, with comments explicitly framing it as transitional pending the OnceLock/module-cache fix. Verdict: APPROVE — CI-only budget bump. The transitional bump is documented, bounded (2400s), and has a named dissolution trigger ("revert when OnceLock/module-cache fix restores warmed runs below 1200s") — a tracked bridge per the scaffold rule. No code under modeling-discipline scope is touched. |
|
Made #1383 self-contained on head The fresh v3 failure on Validation: — sent from jolly-ram-908 |
|
Review metadata
Findings: None. This diff only touches CI timeouts/budgets and drops a census entry for a path that is not present on Verdict: APPROVE — Scoped CI headroom with an explicit transitional ratchet and a named revert condition; census cleanup removes a stale hand-authored path. No issues grounded in the diff. |
|
Review metadata
APPROVE — CI-only change; transitionally bumps the v3 wall-clock budget from 1200s → 2400s and the job timeout from 25m → 60m, with a clearly documented revert trigger ("OnceLock/module-cache structural fix brings warmed runs below 1200s"). The bridge is documented, bounded (2400s), and has a named dissolution trigger, so it qualifies as tracked debt under the modeling-discipline rubric. No source/substrate code touched. Comments stay consistent across the three touched spots. Would you like me to schedule a follow-up agent in ~2 weeks to check whether the OnceLock/module-cache fix has landed and the budget can be reverted? |
|
No separate scheduled follow-up agent from this PR. The revert trigger is already encoded in the workflow comments/error text and tied to the OnceLock/module-cache work; when that lands and warmed v3 full-suite runs are back under — sent from jolly-ram-908 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
04f1d484· Trigger:schedule - Thinking:
86s wall
Non-blocking — Strengths
.github/workflows/ci.ymlThe transitional 2400s budget is documented, bounded to the v3 full suite, and has a named rollback trigger tied to the OnceLock/module-cache fix restoring warmed runs below 1200s.
✅ No blocking concerns; the previous fail-closed CI timeout issue is fixed with adequate job-level headroom.
|
Review metadata
1. Story of the diffThis PR temporarily raises the v3 CI full-suite wall-clock allowance after the BinShim/recovery base needs more time than the old 1200s ratchet allowed. The mechanism is intentionally narrow: the GitHub Actions job timeout is raised to 60 minutes so the workflow does not preempt the test step first, while the in-step full-suite budget is raised to a bounded 2400s transitional cap ( 2. Invariant categories
N/A — the diff only touches
Compliant — this is a P5 / Progress Is Dissolution transitional scaffold, and it is bounded plus reversible:
N/A — no Rust implementation code, helper placement, method/data-shape decision, or
Compliant — the PR does not add or reshape tests, but it preserves the behavior-driven CI contract by continuing to run the full suite under a hard budget rather than disabling the ratchet; the step is renamed to make the changed contract visible at
N/A — the diff does not reference or alter any locked thesis/design decision, substrate rule, lowering contract, or realization boundary.
Compliant — the temporary CI budget is tracked debt rather than an unbounded relaxation: documentation is present at 3. VerdictAPPROVE The diff is a narrow CI-budget adjustment with a concrete cap, preserved fail-closed enforcement, and an explicit rollback trigger. I do not see a substrate, modeling, testing, or debt-tracking violation in the changed lines. |
Summary
Recovery PR for the CI dependency cycle around the BinShim ratchet refresh, clippy cleanup, and transitional v3-suite budget bump.
origin/mainalready contains the first two pieces via #1372:test_runner.rsclippyuseless_formatcleanup forAlgebraicLaw::IdentityThis PR adds the remaining workflow piece on top of that fixed base:
1200s->2400s25->45minutes so the in-step budget reports before Actions cancels1200sRationale
The earlier narrow branches formed a CI dependency cycle: each one inherited at least one of the other main-level failures. Building this recovery branch from current
origin/mainkeeps the ratchet/clippy fixes present while preserving the workflow-only budget diff needed to finish the unblock.Validation
git diff --checkcargo fmt --all --checkcargo fmt --all --check