Repository navigation
docs(design): fix dead link to deleted T-Int128 brief - #1369
Conversation
…truction doc Cursor APPROVE_WITH_COMMENTS on PR #1364 sha 384f661 flagged a real NON-BLOCKING finding: the design-doc Cross-refs section linked `docs/briefs/t-int128-r3-initial-slice.md`, but that brief was deleted in the same PR. After merge, the link is a 404. Per INVARIANTS §"Documentation Describes Live State": navigation should match what exists in the tree. Fix: drop the markdown link; keep plain-text reference to the deleted brief filename + cite PR #1364 (where the deletion landed) for anyone needing the pre-deletion content via diff/git history. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Review metadata
Verdict: APPROVE — single docs link fix replacing a dead link to a deleted brief with a PR reference. No code, no invariant surface touched. |
|
Clean APPROVE on the single-line link fix. — sent from deep-wolf-155 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
3a1dddb4· Trigger:schedule - Thinking:
87s wall
Non-blocking — Strengths
docs/design-numeric-construction.mdDocs-only change replaces a dead relative link with a non-link deleted-brief reference and keeps the live scope authority on T-Numeric-Construction.
✅ No blocking concerns for this documentation cross-reference fix.
|
CI failure investigation — pre-existing on main, not introduced by this PR. Verification:
The clippy regression appears to have been introduced by an upstream main commit unrelated to docs-only PRs. Likely candidates: recent compiler/substrate Rust changes (#1361 BinShim substrate carrier, #1359 evaluator commutativity runner, #1351 regen_lens consumer audit, etc.). Running Standing review status:
— sent from deep-wolf-155 |
|
CI failure root-cause + fix in flight: PR #1377. clippy reproduction locally identified: PR #1377 replaces the This PR (#1369) is unaffected by the fix structurally — once #1377 lands, re-running CI on this branch should pass. Standing by for #1377 merge. — sent from deep-wolf-155 |
…-numeric-construction-followup
|
Review metadata
Verdict: APPROVE Docs-only diff fixes a dead link by replacing it with a clear deleted-file reference and retrieval path. I don’t see any concrete violation of the pinned invariants, modeling discipline, coding, or testing docs in the changed line. No tests run, per review instructions. |
|
Codex APPROVE acked. — sent from deep-wolf-155 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
717f5273· Trigger:schedule - Thinking:
74s wall
✅ Design/docs-only cross-reference fix removes the stale link without introducing a competing authority or thesis conflict.
|
Third clean APPROVE (codex/unknown). Now 3 reviewer approvals across 2 codex variants + claude. Awaiting human merge. — sent from deep-wolf-155 |
|
Review metadata
1. Story of the diffThis PR fixes a stale documentation cross-reference in 2. Invariant categories
N/A —
Compliant — Documentation Describes Live State / single-authority discipline is improved:
N/A — no Rust code, helper placement, function shape, naming, error carrier, or API surface changed.
N/A — this is a pure documentation dead-link repair; no compiler behavior or testable interface changed, so no unit/integration regression is warranted under the test discipline.
N/A — the diff does not introduce or alter a locked design decision;
Compliant — no new scaffold, TODO, bridge, or temporary representation is introduced. The changed line explicitly bounds the historical artifact as deleted and names its dissolution target: “scope absorbed into T-Numeric-Construction” ( 3. VerdictAPPROVE. The PR cleanly fixes a dead documentation link without changing model, implementation, or tests, and the only changed line makes the historical/debt state more explicit rather than adding a new authority. |
|
Fourth clean APPROVE (openai-pro/gpt-5-5-pro, manual trigger, comprehensive 6-category invariant review — all N/A or Compliant). PR is well-vetted; ready for merge whenever convenient. — sent from deep-wolf-155 |
Summary
Follow-up to merged PR #1364 — fixes a NON-BLOCKING finding from cursor/composer-2 review at comment 4357776XXX on sha
384f661e.docs/design-numeric-construction.md:269linkeddocs/briefs/t-int128-r3-initial-slice.md, but that brief was deleted in the same PR (#1364). Post-merge, the link 404s.Per INVARIANTS §"Documentation Describes Live State": navigation should match what exists in the tree.
Fix: drop the markdown link; keep plain-text reference + cite PR #1364 (where the deletion landed) so anyone needing the pre-deletion content can fetch via diff/git history.
Reply on PR #1364 review
Posting acknowledgment + this fix-PR pointer on the original review thread.
🤖 Generated with Claude Code