Skip to content

docs(design): fix dead link to deleted T-Int128 brief - #1369

Merged
briansrls merged 2 commits into
mainfrom
session/deep-wolf-155-numeric-construction-followup
May 1, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/deep-wolf-155-numeric-construction-followup

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Summary

Follow-up to merged PR #1364 — fixes a NON-BLOCKING finding from cursor/composer-2 review at comment 4357776XXX on sha 384f661e.

docs/design-numeric-construction.md:269 linked docs/briefs/t-int128-r3-initial-slice.md, but that brief was deleted in the same PR (#1364). Post-merge, the link 404s.

Per INVARIANTS §"Documentation Describes Live State": navigation should match what exists in the tree.

Fix: drop the markdown link; keep plain-text reference + cite PR #1364 (where the deletion landed) so anyone needing the pre-deletion content can fetch via diff/git history.

Reply on PR #1364 review

Posting acknowledgment + this fix-PR pointer on the original review thread.

🤖 Generated with Claude Code

…truction doc

Cursor APPROVE_WITH_COMMENTS on PR #1364 sha 384f661 flagged a real
NON-BLOCKING finding: the design-doc Cross-refs section linked
`docs/briefs/t-int128-r3-initial-slice.md`, but that brief was
deleted in the same PR. After merge, the link is a 404.

Per INVARIANTS §"Documentation Describes Live State": navigation
should match what exists in the tree.

Fix: drop the markdown link; keep plain-text reference to the deleted
brief filename + cite PR #1364 (where the deletion landed) for anyone
needing the pre-deletion content via diff/git history.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: 3a1dddb4 · Trigger: schedule
  • Comparison: origin/main @ c1054988 ... review/pr-1369-3a1dddb4 @ 3a1dddb4
  • Thinking: 24s wall

Verdict: APPROVE — single docs link fix replacing a dead link to a deleted brief with a PR reference. No code, no invariant surface touched.

@briansrls

Copy link
Copy Markdown
Contributor Author

Clean APPROVE on the single-line link fix. — sent from deep-wolf-155

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 3a1dddb4 · Trigger: schedule
  • Thinking: 87s wall

Non-blocking — Strengths

  • docs/design-numeric-construction.md Docs-only change replaces a dead relative link with a non-link deleted-brief reference and keeps the live scope authority on T-Numeric-Construction.

✅ No blocking concerns for this documentation cross-reference fix.

@briansrls

Copy link
Copy Markdown
Contributor Author

CI failure investigation — pre-existing on main, not introduced by this PR.

Verification:

The clippy regression appears to have been introduced by an upstream main commit unrelated to docs-only PRs. Likely candidates: recent compiler/substrate Rust changes (#1361 BinShim substrate carrier, #1359 evaluator commutativity runner, #1351 regen_lens consumer audit, etc.).

Running cargo clippy --workspace -- -D warnings locally to identify the specific failing surface; will route to the appropriate Mgr (likely Substrate or Evaluator) when output completes. This PR's docs-only change cannot affect clippy output; merge-readiness should be human-decided based on whether CI green is required for docs-only fixes when main itself is RED.

Standing review status:

  • claude-opus-4-7 APPROVE ✓
  • codex APPROVE ✓ ("No blocking concerns for this documentation cross-reference fix")

— sent from deep-wolf-155

@briansrls

Copy link
Copy Markdown
Contributor Author

CI failure root-cause + fix in flight: PR #1377.

clippy reproduction locally identified: src/v3/compiler/src/test_runner.rs:2400 — clippy::useless-format (format! macro with no placeholders on the AlgebraicLaw::Identity is blocked not-yet-implemented arm). Likely from #1359 algebraic commutativity runner work.

PR #1377 replaces the format!() with .to_string() per clippy suggestion. Verified locally: cargo clippy --workspace -- -D warnings passes after fix.

This PR (#1369) is unaffected by the fix structurally — once #1377 lands, re-running CI on this branch should pass. Standing by for #1377 merge.

— sent from deep-wolf-155

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: codex / codex-default
  • Commit: 717f5273 · Trigger: schedule
  • Comparison: origin/main @ 8f051650 ... review/pr-1369-717f5273 @ 717f5273
  • Thinking: 22s wall

Verdict: APPROVE

Docs-only diff fixes a dead link by replacing it with a clear deleted-file reference and retrieval path. I don’t see any concrete violation of the pinned invariants, modeling discipline, coding, or testing docs in the changed line.

No tests run, per review instructions.

@briansrls

Copy link
Copy Markdown
Contributor Author

Codex APPROVE acked. — sent from deep-wolf-155

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 717f5273 · Trigger: schedule
  • Thinking: 74s wall

✅ Design/docs-only cross-reference fix removes the stale link without introducing a competing authority or thesis conflict.

@briansrls

Copy link
Copy Markdown
Contributor Author

Third clean APPROVE (codex/unknown). Now 3 reviewer approvals across 2 codex variants + claude. Awaiting human merge. — sent from deep-wolf-155

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: openai-pro / gpt-5-5-pro
  • Commit: 717f5273 · Trigger: manual
  • Comparison: main @ 8f051650 ... session/deep-wolf-155-numeric-construction-followup @ 717f5273
  • Conversation: View conversation

1. Story of the diff

This PR fixes a stale documentation cross-reference in docs/design-numeric-construction.md. The old line treated docs/briefs/t-int128-r3-initial-slice.md as a live relative Markdown link even though the brief had been deleted; the new line keeps the deleted path as inline code, records that deletion happened in PR #1364, and tells readers where historical content can be inspected while preserving the important design fact that the scope was absorbed into T-Numeric-Construction (docs/design-numeric-construction.md:269). No compiler behavior, substrate model, or design authority changes; this is a live-state documentation repair.

2. Invariant categories

  1. LAYER MODEL (substrate vs implementation).

N/A — docs/design-numeric-construction.md:269 is documentation-only; it does not touch Dag-resident substrate types, cross-pass facts, dag.rs, or implementation code.

  1. INVARIANTS.md + modeling-discipline.md.

Compliant — Documentation Describes Live State / single-authority discipline is improved: docs/design-numeric-construction.md:269 no longer links to a deleted brief as though it were live authority, and instead states that the scope is absorbed into T-Numeric-Construction.

  1. CODING.md.

N/A — no Rust code, helper placement, function shape, naming, error carrier, or API surface changed.

  1. TESTING.md.

N/A — this is a pure documentation dead-link repair; no compiler behavior or testable interface changed, so no unit/integration regression is warranted under the test discipline.

  1. LOCKED DESIGN DECISIONS.

N/A — the diff does not introduce or alter a locked design decision; docs/design-numeric-construction.md:269 only updates provenance for a superseded brief.

  1. TRACKED vs UNTRACKED DEBT.

Compliant — no new scaffold, TODO, bridge, or temporary representation is introduced. The changed line explicitly bounds the historical artifact as deleted and names its dissolution target: “scope absorbed into T-Numeric-Construction” (docs/design-numeric-construction.md:269).

3. Verdict

APPROVE. The PR cleanly fixes a dead documentation link without changing model, implementation, or tests, and the only changed line makes the historical/debt state more explicit rather than adding a new authority.

@briansrls

Copy link
Copy Markdown
Contributor Author

Fourth clean APPROVE (openai-pro/gpt-5-5-pro, manual trigger, comprehensive 6-category invariant review — all N/A or Compliant). PR is well-vetted; ready for merge whenever convenient. — sent from deep-wolf-155

@briansrls
briansrls merged commit 819cdcb into main May 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant