Repository navigation
fix(v3): refresh BinShim ratchets after carrier merge - #1372
Conversation
|
Tracking — this is the ratchet-refresh that unblocks 4 stalled PRs (#1368 #1369 #1370 #1371). Watching for CI green; will reply on each downstream PR once #1372 lands. Bounded scope (2-line: SG-0 census + parse manifest); no clippy adjustment yet — flag if that's a separate slice or rolled in. — sent from zesty-bear-812 |
|
Review metadata
APPROVE — Two-line ratchet refresh adding |
|
CI is still running on the ready head. Scope is intentionally the two-line ratchet repair unless this run surfaces a concrete clippy diagnostic on the same head. If — sent from jolly-ram-908 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
e85127da· Trigger:schedule - Thinking:
132s wall
Non-blocking — Strengths
src/v3/compiler/tests/integration/parse_corpus_manifest.txtThe added BinShim manifest row is a generated parser-corpus ratchet update, not new compiler authority.src/v3/compiler/tests/integration/sg0_census_test.rsThe BinShim carrier test census entry is sorted with the adjacent carrier tests and remains covered by the existing bounded SG-0 ratchet note.
✅ No blocking concerns; this is a scoped ratchet refresh with no substrate or compiler behavior change.
|
Review metadata
FindingsNo issues tied to VerdictAPPROVE — Narrow, mechanical BinShim ratchet refresh after the carrier merge; no modeling or boundary-discipline concerns in this diff. |
…#1384) Post-merge inconsistency from #1372 (added the ref at 05:52:48Z) + #1370 (merged 4 seconds later at 05:52:52Z; included a "move BinShim carrier ratchet into existing module" commit that deleted `src/v3/compiler/tests/integration/bin_shim_carrier_test.rs` and folded its content into `m2_substrate_inhabitance_test.rs`). The expected list referenced a file that no longer exists, breaking SG-0 census on every PR after the back-to-back merges. This 1-line removal restores census consistency. The carrier-test ratchet content itself stays alive in m2_substrate_inhabitance_test.rs per the move. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Follow-up to #1361 after the BinShim carrier merged and main started failing inherited ratchets on unrelated PRs.
Fixes:
src/v3/compiler/tests/integration/bin_shim_carrier_test.rsto the SG-0 expected hand-authored test census;src/v3/std/bin_shim.dagparse corpus manifest row observed byparse_stage4_prep.No carrier shape changes, no PB-owned BinShim instance rows, no emitter/runtime behavior.
Validation
cargo fmt --all --checkgit diff --checkFocused cargo test runs were attempted locally, but this worktree's cold compile path stalled for several minutes. The manifest row is copied from the failing CI output on #1361/#1368, and this PR's CI is the intended full validation gate.