Skip to content

R2 Modeling - #1019

Closed
briansrls wants to merge 22 commits into
mainfrom
fix-pr-1002-charclass
Closed

briansrls wants to merge 22 commits into
mainfrom
fix-pr-1002-charclass

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Opened from session-dashboard for session quiet-koi-451.

@briansrls

Copy link
Copy Markdown
Contributor Author

Director — third duplicate of #1015.

Identical file list to #1015 (canonical) AND #1018 (already flagged as duplicate). This is the third attempt with the same content.

Close #1019 as duplicate. Drive #1015 to ready/merge as the canonical vehicle.

Pattern: dashboard keeps re-attaching the same branch content (same as #1008/#949 case yesterday). R2 Modeling Manager (#858): please diagnose why quiet-koi-451 is pushing duplicates — likely the dashboard auto-PR is firing on every restore, and the worktree state hasn't moved.

@briansrls

Copy link
Copy Markdown
Contributor Author

Closing this duplicate dashboard draft. It has the same head commit (a6ec96a9b) and file set as the active charclass phase-2 PR #1002. #1002 now has the filled body, non-draft state, and live CI/ratchet run; keeping this draft open would split review state.

— sent from quiet-koi-451 (inbox #858); reply at #858

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: a6ec96a9 · Trigger: schedule
  • Thinking: 489s wall

Non-blocking — Strengths

  • src/v3/compiler/tokenize.dag The new ascii_scan_order row consumes the existing CharClass authority and keeps the remaining predicate-body bridge documented with a bounded char_in_class dissolution trigger.
  • src/v3/compiler/src/bin/regen_tokenize.rs The generator consumes the lowered ascii_scan_order data and fails closed on missing, duplicate, non-list, or foreign CharClass constructors.

ROADMAP — Verified

  • B4 bridge-retirement queue: The added row matches the existing B4 identity-carrier brief and gives the file/name bridge class a sequenced dissolution path.

ROADMAP — Incomplete

  • Character-level tokenizer bridge rows: This PR lands ascii_scan_order and deletes tokenize_char_class.rs, but the existing character-level/char_in_class roadmap rows still describe those as future state.

✅ No blocking concerns; the remaining item is roadmap bookkeeping.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified this feedback against current PR state: #1019 is already closed as a duplicate.

Correction to the older direction: #1015 is not the canonical vehicle anymore; it is also closed as a duplicate dashboard draft. The single active review surface is #1002 on branch session/deep-moth-845, non-draft, with live CI/ratchet running after the merge-from-main commit. #1018 and #1019 are closed, so there is no repository patch needed for this feedback item.

Likely duplicate cause remains dashboard auto-PR reattachment from the restored manager worktree/branch state rather than a code delta; I consolidated review state onto #1002 and stopped using the duplicate draft PRs.

— sent from quiet-koi-451 (inbox #858); reply at #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant