Skip to content

helm: Make auth type configurable#7508

Merged
webvictim merged 4 commits intogravitational:masterfrom
agurgel-te:authentication_type
Aug 20, 2021
Merged

helm: Make auth type configurable#7508
webvictim merged 4 commits intogravitational:masterfrom
agurgel-te:authentication_type

Conversation

@agurgel-te
Copy link
Copy Markdown
Contributor

@agurgel-te agurgel-te commented Jul 8, 2021

This allows a Helm user to configure the authentication type used by teleport-cluster. In my case, I need GitHub.

Similar to #7450.

@russjones russjones added the helm label Jul 14, 2021
webvictim
webvictim reviewed Aug 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@webvictim webvictim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonio-te Looks great - could you please also add authenticationType to the correct section of https://github.com/gravitational/teleport/blob/master/docs/pages/kubernetes-access/helm/reference.mdx ?

Once that's done I can approve.

Comment thread examples/chart/teleport-cluster/values.yaml Outdated
@jonaskello
Copy link
Copy Markdown

jonaskello commented Aug 19, 2021

I was looking for exactly this. The only other way I find to do it would be to run the chart in custom mode but it seems that is not a recommended mode. What is stopping the merge now?

@webvictim
Copy link
Copy Markdown
Contributor

webvictim commented Aug 19, 2021

I’ve asked the author to add the value to the Helm chart reference in our docs. Once that’s done we can approve and merge it.

@webvictim
Copy link
Copy Markdown
Contributor

webvictim commented Aug 19, 2021

@antonio-te Please take a look at my previous comment.

@agurgel-te
Copy link
Copy Markdown
Contributor Author

agurgel-te commented Aug 19, 2021

I could have sworn I force-pushed a new commit including the suggested change.

@jonaskello
Copy link
Copy Markdown

jonaskello commented Aug 19, 2021 •
edited
Loading

Nicely done :-). I would like to use this as soon as possible. What frequency are the helm charts are published at? I cannot seem to find any helm chart newer than 6 which seems old since teleport 7.0.3 has ben released?

@webvictim webvictim enabled auto-merge (squash) August 19, 2021 21:13
russjones
russjones approved these changes Aug 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@webvictim webvictim merged commit 9c01ca2 into gravitational:master Aug 20, 2021
webvictim added a commit that referenced this pull request Aug 20, 2021
@agurgel-te @webvictim
helm: Make auth type configurable (#7508)
3adde6f 
Co-authored-by: Gus Luxton <gus@goteleport.com>
@webvictim webvictim mentioned this pull request Aug 20, 2021
Merged
webvictim added a commit that referenced this pull request Aug 26, 2021
@webvictim @stefansedich
@agurgel-te @amemni
branch/v7: Helm backports (#8007)
f88bc60 
* Add abilty to configure postStart handler for teleport-cluster chart (#7168)

* Add support for PDB with the teleport-cluster helm chart (#7138)

* Allow teleport-cluster-agent chart to use an existing volume for the data directory (#7096)

* Mount teleport-tls to the init container for the teleport-cluster helm chart (#7166)

* add support for running agent helm chart on persistent volume (#7123)

* helm: Make auth type configurable (#7508)

* Add imagePullSecrets in kube-agent chart (#6941)

Co-authored-by: Gus Luxton <gus@goteleport.com>
Co-authored-by: Stefan Sedich <stefan.sedich@gmail.com>
Co-authored-by: Kevin Nisbet <kevin@gravitational.com>
Co-authored-by: Antonio Gurgel <66754096+antonio-te@users.noreply.github.com>
Co-authored-by: Aymen Memni <7290430+amemni@users.noreply.github.com>
zmb3 pushed a commit that referenced this pull request Sep 23, 2021
@agurgel-te @webvictim @zmb3
helm: Make auth type configurable (#7508)
d5d9b64 
Co-authored-by: Gus Luxton <gus@goteleport.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webvictim webvictim webvictim approved these changes

@russjones russjones russjones approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

@r0mant r0mant Awaiting requested review from r0mant

Assignees

@webvictim webvictim

Labels

helm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agurgel-te @jonaskello @webvictim @russjones