Allow teleport-cluster-agent chart to use an existing volume for the data directory#7096
Conversation
stefansedich
requested review from
klizhentas,
r0mant and
russjones
as code owners
stefansedich
force-pushed
the
teleport-cluster-agent-volume
branch
from
c57fb4f to
ef336d7
Compare
|
Hi @stefansedich Thanks for your first PR. I've assigned @webvictim to review this PR |
|
@webvictim wondering if you had a chance to look over this PR, let me know if there is anything I need to change to get it merged. |
|
@webvictim Can you review? |
webvictim
left a comment
webvictim
left a comment
There was a problem hiding this comment.
I think that this change itself is OK - there's another PR in #7123 which also modifies this behaviour, but I consider this
approach to be much simpler and easier to understand.
Please add this value to the Helm chart reference at https://github.com/gravitational/teleport/blob/master/docs/pages/kubernetes-access/helm/reference.mdx so it's kept up to date.
…to teleport-cluster-agent-volume
Docs added @webvictim this should be good to go! |
webvictim
left a comment
webvictim
left a comment
There was a problem hiding this comment.
@stefansedich Thanks - this will be merged once it has another approving review.
|
@inertial-frame what was needed now to get this PR in? I would love to move off our fork. |
|
@stefansedich He’s no longer with Teleport, this one just needs a rubber stamp. |
|
@webvictim Please backport this to |
…data directory (#7096) * Allow teleport-cluster-agent chart to use an existing volume for the data Co-authored-by: Gus Luxton <gus@goteleport.com>
* Add abilty to configure postStart handler for teleport-cluster chart (#7168) * Add support for PDB with the teleport-cluster helm chart (#7138) * Allow teleport-cluster-agent chart to use an existing volume for the data directory (#7096) * Mount teleport-tls to the init container for the teleport-cluster helm chart (#7166) * add support for running agent helm chart on persistent volume (#7123) * helm: Make auth type configurable (#7508) * Add imagePullSecrets in kube-agent chart (#6941) Co-authored-by: Gus Luxton <gus@goteleport.com> Co-authored-by: Stefan Sedich <stefan.sedich@gmail.com> Co-authored-by: Kevin Nisbet <kevin@gravitational.com> Co-authored-by: Antonio Gurgel <66754096+antonio-te@users.noreply.github.com> Co-authored-by: Aymen Memni <7290430+amemni@users.noreply.github.com>
…data directory (#7096) * Allow teleport-cluster-agent chart to use an existing volume for the data Co-authored-by: Gus Luxton <gus@goteleport.com>
5 participants
We need to be able to mount an existing persisted volume for our data directory. This PR allows the user to use another volume via
extraVolumesand then change the volume used for the data directory mount.It keeps the existing behavior of creating the
emptyDirvolume by default but onceexistingDataVolumeis set it will not create the volume anymore and assume the user has added the volume viaextraVolumes.