helm: make aws service annotations configurable

[tghaas]

This would allow a user to keep the default configuration for the AWS K8s service object but also allow modification of that within values.yaml. Main use case is if you are using the AWS Load Balancer Controller, this allows you to change the annotations so it can control the service instead of the built-in controller.

[webvictim]

I'd prefer a way to conditionally disable the default AWS service annotations without needing to set defaultServiceAnnotations to true for every single AWS install that doesn't need/want to change them. I'm trying to keep the install commands to be essentials only to avoid people having to set lots of extra parameters that they don't need to understand.

Maybe something like this:

annotations:
  serviceSetAWSDefaults: false
  service:
    aws-special-param: blah
    another-aws-param: something

• If serviceSetAWSDefaults isn't set, it should default to true.
• If serviceSetAWSDefaults is set to true but the chart isn't running in AWS mode, it should do nothing.

[russjones]

@webvictim Can you take a look? If this is something we want, can you work with @tghaas to fix the conflicts. Then we can get this merged and backported to a release branch.

[russjones]

@tghaas Looks like this PR has not had movement in a few months. I am going to close this for now, if you still want to add this functionality, please re-open or create another PR.