Add support for PDB with the teleport-cluster helm chart#7138
Add support for PDB with the teleport-cluster helm chart#7138webvictim merged 18 commits intogravitational:masterfrom
Conversation
stefansedich
requested review from
klizhentas,
r0mant and
russjones
as code owners
|
@webvictim Can you review this? |
| # If enabled will create a Pod Disruption Budget | ||
| # https://kubernetes.io/docs/concepts/workloads/pods/disruptions/ | ||
| podDisruptionBudget: | ||
| enabled: false | ||
| minAvailable: 1 |
There was a problem hiding this comment.
I think that this should be under the highAvailability section as it's only relevant for that type of deployment.
webvictim
left a comment
webvictim
left a comment
There was a problem hiding this comment.
Added some feedback.
Also, please add this value to the Helm chart reference at https://github.com/gravitational/teleport/blob/master/docs/pages/kubernetes-access/helm/reference.mdx so it's kept up to date.
…to teleport-cluster-pdb
@webvictim feedback implemented and added to the docs. |
|
@stefansedich Thanks! One final thing - could you please add a sample values file See something like https://github.com/gravitational/teleport/blob/master/examples/chart/teleport-cluster/.lint/volumes.yaml for an example. |
There was a problem hiding this comment.
Docs-wise this is great thanks for the helpful reference update!
…to teleport-cluster-pdb
@webvictim done, hopefully I got that right 😄 |
stefansedich
force-pushed
the
teleport-cluster-pdb
branch
from
eb65f38 to
7ede544
Compare
|
@stefansedich Yep, looks good. Let's see what the linter says. |
Co-authored-by: Gus Luxton <webvictim@gmail.com>
…rt into teleport-cluster-pdb
…to teleport-cluster-pdb
|
@webvictim what was needed now to get this in? |
|
Looks fine now. @klizhentas @r0mant @russjones Please codeowner review. |
|
@webvictim @klizhentas @r0mant @russjones any chance of getting this one in? |
|
This is fine by me, just needs a rubber stamp from @russjones @klizhentas or @r0mant. |
|
@webvictim Please backport this to |
* Add support for PDB with the teleport-cluster helm chart Co-authored-by: Gus Luxton <gus@goteleport.com>
* Add abilty to configure postStart handler for teleport-cluster chart (#7168) * Add support for PDB with the teleport-cluster helm chart (#7138) * Allow teleport-cluster-agent chart to use an existing volume for the data directory (#7096) * Mount teleport-tls to the init container for the teleport-cluster helm chart (#7166) * add support for running agent helm chart on persistent volume (#7123) * helm: Make auth type configurable (#7508) * Add imagePullSecrets in kube-agent chart (#6941) Co-authored-by: Gus Luxton <gus@goteleport.com> Co-authored-by: Stefan Sedich <stefan.sedich@gmail.com> Co-authored-by: Kevin Nisbet <kevin@gravitational.com> Co-authored-by: Antonio Gurgel <66754096+antonio-te@users.noreply.github.com> Co-authored-by: Aymen Memni <7290430+amemni@users.noreply.github.com>
* Add support for PDB with the teleport-cluster helm chart Co-authored-by: Gus Luxton <gus@goteleport.com>
4 participants
This PR adds support for a PDB as part of the teleport-cluster chart, for the sole reason that if we truly want to support HA then we should likely configure a PDB.
I have disabled it by default and have made it an opt-in thing, we can also enable it when
replicaCount>1so am open to suggestions.