Skip to content

[v13] Update e#37679

Merged
wadells merged 4 commits intobranch/v13from
walt/v13-bump-e
Feb 9, 2024
Merged

[v13] Update e#37679
wadells merged 4 commits intobranch/v13from
walt/v13-bump-e

Conversation

@wadells
Copy link
Copy Markdown
Contributor

@wadells wadells commented Feb 1, 2024

Includes changes from https://github.com/gravitational/teleport.e/pull/2978 / backports.

I'll be removing the staging enviroment (replaced by build-stage / publish-stage) and builds will no longer work without this change.

@wadells wadells added the no-changelog Indicates that a PR does not require a changelog entry label Feb 1, 2024
@wadells wadells changed the title Update e [v13] Update e Feb 1, 2024
@github-actions github-actions Bot requested review from klizhentas and zmb3 February 1, 2024 20:50
@wadells
Copy link
Copy Markdown
Contributor Author

wadells commented Feb 5, 2024

Someone got to this before me.

Edit: no -- they only updated e to the commit before my change.

@wadells wadells closed this Feb 6, 2024
@wadells wadells reopened this Feb 7, 2024
@wadells wadells added this pull request to the merge queue Feb 8, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 8, 2024
@wadells wadells enabled auto-merge February 8, 2024 01:28
@wadells
Copy link
Copy Markdown
Contributor Author

wadells commented Feb 8, 2024

Looks like #37877 broke Lint (Go) in v13 which will prevent anything from merging. I'll take a look at it tomorrow if @codingllama doesn't beat me to it.

@codingllama
Copy link
Copy Markdown
Contributor

o.O

$ cd integrations/kube-agent-updater

$ pwd
(...)/teleport/integrations/kube-agent-updater

$ golangci-lint run -c ../../.golangci.yml .
# exit code: 0
# so far so good

$ golangci-lint run -c ../../.golangci.yml ./...
ERRO Running error: context loading failed: no go files to analyze
# exit code: 5
# what?

$ find . -name '*.go'
./cmd/teleport-kube-agent-updater/constants.go
./cmd/teleport-kube-agent-updater/main.go
./version.go
./hack/cosign-fixtures.go
./pkg/basichttp/servermock.go
./pkg/basichttp/client.go
./pkg/cache/error.go
./pkg/cache/cache_test.go
./pkg/cache/cache.go
./pkg/constants/constants.go
./pkg/podutils/filter_test.go
./pkg/podutils/filter.go
./pkg/podutils/utils.go
./pkg/controller/deployment.go
./pkg/controller/utils_test.go
./pkg/controller/statefulset.go
./pkg/controller/updater.go
./pkg/controller/constants.go
./pkg/controller/updater_test.go
./pkg/controller/utils.go
./pkg/controller/statefulset_test.go
./pkg/controller/suite_test.go
./pkg/controller/errors.go
./pkg/img/insecure.go
./pkg/img/validator.go
./pkg/img/cosign_test.go
./pkg/img/cosign_fixtures_test.go
./pkg/img/doc.go
./pkg/img/cosign.go
./pkg/img/nop.go
./pkg/img/nop_test.go
./pkg/img/mock.go
./pkg/img/errors.go
./pkg/version/basichttp.go
./pkg/version/versionget_test.go
./pkg/version/basichttp_test.go
./pkg/version/mock.go
./pkg/version/versionget.go
./pkg/version/errors.go
./pkg/maintenance/window.go
./pkg/maintenance/basichttp.go
./pkg/maintenance/basichttp_test.go
./pkg/maintenance/unhealthy.go
./pkg/maintenance/unhealthy_test.go
./pkg/maintenance/mock.go
./pkg/maintenance/trigger.go
./pkg/maintenance/window_test.go

@codingllama
Copy link
Copy Markdown
Contributor

The linter is failing because kube-agent-updater/go.mod is actually incorrect / untidy. Since #34462 the min Go version required for the module is 1.21 due to github.com/sigstore/cosign/v2 v2.2.1. I'll push a PR shortly.

auto-merge was automatically disabled February 8, 2024 22:56

Merge queue setting changed

@wadells wadells enabled auto-merge February 9, 2024 00:07
@wadells wadells added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@wadells wadells added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@codingllama
Copy link
Copy Markdown
Contributor

@wadells wadells enabled auto-merge February 9, 2024 17:11
@wadells wadells added this pull request to the merge queue Feb 9, 2024
Merged via the queue into branch/v13 with commit 22704e9 Feb 9, 2024
@wadells wadells deleted the walt/v13-bump-e branch February 9, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport no-changelog Indicates that a PR does not require a changelog entry size/sm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants