Merged
Conversation
fheinecke
approved these changes
Feb 1, 2024
tcsc
approved these changes
Feb 1, 2024
Contributor
Author
|
Edit: no -- they only updated |
770708e to
cb21970
Compare
r0mant
approved these changes
Feb 8, 2024
Contributor
Author
|
Looks like #37877 broke Lint (Go) in v13 which will prevent anything from merging. I'll take a look at it tomorrow if @codingllama doesn't beat me to it. |
Contributor
|
o.O $ cd integrations/kube-agent-updater
$ pwd
(...)/teleport/integrations/kube-agent-updater
$ golangci-lint run -c ../../.golangci.yml .
# exit code: 0
# so far so good
$ golangci-lint run -c ../../.golangci.yml ./...
ERRO Running error: context loading failed: no go files to analyze
# exit code: 5
# what?
$ find . -name '*.go'
./cmd/teleport-kube-agent-updater/constants.go
./cmd/teleport-kube-agent-updater/main.go
./version.go
./hack/cosign-fixtures.go
./pkg/basichttp/servermock.go
./pkg/basichttp/client.go
./pkg/cache/error.go
./pkg/cache/cache_test.go
./pkg/cache/cache.go
./pkg/constants/constants.go
./pkg/podutils/filter_test.go
./pkg/podutils/filter.go
./pkg/podutils/utils.go
./pkg/controller/deployment.go
./pkg/controller/utils_test.go
./pkg/controller/statefulset.go
./pkg/controller/updater.go
./pkg/controller/constants.go
./pkg/controller/updater_test.go
./pkg/controller/utils.go
./pkg/controller/statefulset_test.go
./pkg/controller/suite_test.go
./pkg/controller/errors.go
./pkg/img/insecure.go
./pkg/img/validator.go
./pkg/img/cosign_test.go
./pkg/img/cosign_fixtures_test.go
./pkg/img/doc.go
./pkg/img/cosign.go
./pkg/img/nop.go
./pkg/img/nop_test.go
./pkg/img/mock.go
./pkg/img/errors.go
./pkg/version/basichttp.go
./pkg/version/versionget_test.go
./pkg/version/basichttp_test.go
./pkg/version/mock.go
./pkg/version/versionget.go
./pkg/version/errors.go
./pkg/maintenance/window.go
./pkg/maintenance/basichttp.go
./pkg/maintenance/basichttp_test.go
./pkg/maintenance/unhealthy.go
./pkg/maintenance/unhealthy_test.go
./pkg/maintenance/mock.go
./pkg/maintenance/trigger.go
./pkg/maintenance/window_test.go |
Contributor
|
The linter is failing because kube-agent-updater/go.mod is actually incorrect / untidy. Since #34462 the min Go version required for the module is 1.21 due to github.com/sigstore/cosign/v2 v2.2.1. I'll push a PR shortly. |
auto-merge was automatically disabled
February 8, 2024 22:56
Merge queue setting changed
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes changes from https://github.com/gravitational/teleport.e/pull/2978 / backports.
I'll be removing the
stagingenviroment (replaced bybuild-stage/publish-stage) and builds will no longer work without this change.