Skip to content

WebDiscover: Add delete integration operation#24590

Merged
kimlisa merged 7 commits intomasterfrom
lisa/allow-delete-integrations
Apr 14, 2023
Merged

WebDiscover: Add delete integration operation#24590
kimlisa merged 7 commits intomasterfrom
lisa/allow-delete-integrations

Conversation

@kimlisa
Copy link
Copy Markdown
Contributor

@kimlisa kimlisa commented Apr 14, 2023

part of #22129
enterprise PR: https://github.com/gravitational/teleport.e/pull/1140

  • fix bug: delete endpoint didn't return a valid OK json message, resulting in malformed json error message
  • fix making of integrations list response (forgot it was paginated)
  • allow deleting integrations
  • create a re-usable integration operation hook for use with enterprise version (only supports delete for now)

Screenshot

image

@kimlisa kimlisa requested review from ryanclark and removed request for ravicious April 14, 2023 08:18
@kimlisa kimlisa force-pushed the lisa/allow-delete-integrations branch from 2de7cf8 to 4455462 Compare April 14, 2023 09:59
@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from ibeckermayer April 14, 2023 15:22
@kimlisa kimlisa enabled auto-merge April 14, 2023 15:54
@kimlisa kimlisa added this pull request to the merge queue Apr 14, 2023
Merged via the queue into master with commit c17a9da Apr 14, 2023
@kimlisa kimlisa deleted the lisa/allow-delete-integrations branch April 14, 2023 16:37
kimlisa added a commit that referenced this pull request May 3, 2023
* Fix malformed JSON error response for 200

* Fix making response when fetching integrations

* Create re-usable integration ops hook (only delete for now)

* Create delete dialog

* Allow deleting integrations

* Fix lint
kimlisa added a commit that referenced this pull request May 4, 2023
* WebDiscover: Enroll New AWS Integration Flow (#24459)

* Add Lock icon

* WebDiscover: Create connect to aws account screen (#24506)

* WebDiscover: Add delete integration operation (#24590)

* Fix malformed JSON error response for 200

* Fix making response when fetching integrations

* Create re-usable integration ops hook (only delete for now)

* Create delete dialog

* Allow deleting integrations

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants