WebDiscover: Enroll New AWS Integration Flow#24459
Merged
Conversation
|
@kimlisa - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
ryanclark
approved these changes
Apr 13, 2023
Member
ryanclark
left a comment
ryanclark
left a comment
There was a problem hiding this comment.
LGTM, there's some TODOs to replace the hostname of teleport.lol to the actual cluster name. Can you do these before merging please?
r0mant
approved these changes
Apr 13, 2023
avatus
approved these changes
Apr 13, 2023
* Rename AWS into AwsOidc, story expects pascal case but ran into non-story issues where casing was a problem even renaming AWS to Aws wasn't enough, i don't know why * Capitalize browser directory to Browser
Also define IntegrationKind as enum string values to avoid hard coding it all over.
kimlisa
force-pushed
the
lisa/ryan/enroll-aws-integration
branch
from
283a568 to
61e99f5
Compare
kimlisa
added a commit
that referenced
this pull request
May 3, 2023
kimlisa
added a commit
that referenced
this pull request
May 4, 2023
* WebDiscover: Enroll New AWS Integration Flow (#24459) * Add Lock icon * WebDiscover: Create connect to aws account screen (#24506) * WebDiscover: Add delete integration operation (#24590) * Fix malformed JSON error response for 200 * Fix making response when fetching integrations * Create re-usable integration ops hook (only delete for now) * Create delete dialog * Allow deleting integrations * Fix lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #22129
enterprise PR: https://github.com/gravitational/teleport.e/pull/1123
Recommend reviewing by commit.
Also, this feature is not enabled yet as more work is coming.
Just made minor tweaks on top of ryan's major work:
AWSso i had to change it toAwsOidc, i'm not exactly sure where it rooted from.Note: skipped adding test to save time, i'll add them after branch 13 cut and polishing is necessary. I would probably add a behavioral test that each step renders as expected.
Screenshot & Mov
after creating integration dialog if a user came from discover flow, we will resume by passing in location state to the discover route:
dialog when a user didn't come from discover:
I sped past the animation, storybook contains the flow at your leisure
Integrations/AwsOidc/Flow:Screen.Recording.2023-04-12.at.10.04.00.AM.mov