Conversation
ryanclark
reviewed
May 11, 2023
Member
There was a problem hiding this comment.
Suggested change
| const requiredRoleArn = roleArn => () => { | |
| const requiredRoleArn = (roleArn: string) => () => { |
Member
There was a problem hiding this comment.
I think we should refer them to the value in AWS, not the animation
avatus
approved these changes
May 11, 2023
- Create a re-usable component for rendering dialogues based on operation type (enterprise)
kimlisa
force-pushed
the
lisa/touchup-integrations
branch
from
0a0f94b to
8f56d92
Compare
ryanclark
approved these changes
May 11, 2023
kimlisa
added a commit
that referenced
this pull request
May 16, 2023
* Fix storybook deprecated warning * Define required role arn rule check * Implement editing integrations - Create a re-usable component for rendering dialogues based on operation type (enterprise) * Add thumbprint validation * Fix text color mash in light theme * Address CR
kimlisa
added a commit
that referenced
this pull request
May 16, 2023
* Fix storybook deprecated warning * Define required role arn rule check * Implement editing integrations - Create a re-usable component for rendering dialogues based on operation type (enterprise) * Add thumbprint validation * Fix text color mash in light theme * Address CR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #22133
(implementing deleting integration was already done here: #24590)
enterprise PR: https://github.com/gravitational/teleport.e/pull/1362
restart animationbuttonscreenshot
the edit integration design was not a dialog but its own view, i implemented it as a dialog b/c that is how other edits work in our app
edit integration dialog
on error
invalid thumbprint check
