feat(internal/librarian/nodejs): add metadata_name_override and name_pretty_override support - #6603
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for overriding the name and name_pretty fields in .repo-metadata.json for Node.js packages. It adds metadata_name_override and name_pretty_override configuration options, updates the configuration schema documentation, implements the merging logic, applies the overrides during metadata generation, and includes a unit test to verify the behavior. There are no review comments, and I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for overriding the name and name_pretty fields in .repo-metadata.json for Node.js packages. It adds metadata_name_override and name_pretty_override configuration options, updates the configuration parsing and merging logic, applies these overrides during metadata generation, and includes a unit test to verify the behavior. I have no feedback to provide.
🤖 I have created a release *beep* *boop* --- ## [0.24.0](v0.23.0...v0.24.0) (2026-07-01) ### Features * **add:** handle Release Please config for google-cloud-node ([#6569](#6569)) ([1f8ee00](1f8ee00)) * **internal/librarian/java:** add code snippet extraction helpers for README rendering ([#6593](#6593)) ([96f6925](96f6925)), closes [#6515](#6515) * **internal/librarian/java:** add extractSamples for README generation ([#6578](#6578)) ([b5e3d45](b5e3d45)), closes [#6515](#6515) * **internal/librarian/nodejs:** add metadata_name_override and name_pretty_override support ([#6603](#6603)) ([3f6cfed](3f6cfed)), closes [#6453](#6453) * **internal/librarian:** add debug command with env subcommand ([#6576](#6576)) ([027103b](027103b)), closes [#6374](#6374) * **internal/librarian:** populate Java Maven coordinates from defaults ([#6554](#6554)) ([accb8ad](accb8ad)), closes [#6513](#6513) * **librarian/swift:** use discovery config ([#6604](#6604)) ([5a44ed7](5a44ed7)) * **sidekick/discovery:** signatures without path params ([#6588](#6588)) ([bb40e83](bb40e83)) ### Bug Fixes * **internal/librarian/java:** exclude google-cloud-bom and libraries-bom when generating gapic-libraries-bom/pom.xml ([#6601](#6601)) ([b8e50a5](b8e50a5)) * **internal/serviceconfig:** normalize transport name for Java repo-metadata ([#6582](#6582)) ([e20f77a](e20f77a)) * **sdk.yaml:** allow rust for many non-cloud apis ([#6598](#6598)) ([0efb6e7](0efb6e7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
2 participants
This pull request adds metadata_name_override and name_pretty_override configuration fields to NodejsPackage in librarian.yaml .
Currently, Librarian infers name and name_pretty in
.repo-metadata.jsondirectly from the backend service config ( api.ShortName and api.Title ). When multiple packages share a single serviceauthority (e.g., @google-cloud/dialogflow and @google-cloud/dialogflow-cx both generating from dialogflow.googleapis.com ), Librarian overwrites both
.repo-metadata.jsonfiles with identicalvalues ( "dialogflow" / "Dialogflow" ), causing config collisions.
Adding these override fields aligns Node.js with Java ( name_pretty_override ) and Python ( metadata_name_override ), allowing packages with shared service authorities to explicitly preserve their unique
metadata names.
For #6453