feat(internal/librarian/java): add extractSamples for README generation - #6578
Merged
Conversation
Add helper functions collectSampleFiles and parseCodeSample to scan samples/src/main/java and extract sample metadata. Add codeSample struct and unit tests. For googleapis#6515
…ration Add extractSamples main function to locate Java sample files and return parsed codeSample structs. Add unit tests in readme_test.go. For googleapis#6515
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces functionality to extract, collect, and parse Java code samples from a directory, along with comprehensive unit tests for these new features. The reviewer suggests defining a sentinel error errEmptyDir instead of comparing error strings directly, and updating the corresponding tests to use errors.Is to align with the style guide.
…ction helpers Pre-check samples directory existence, return pointer in parseCodeSample, and clean comments.
…ration Add extractSamples main function to locate Java sample files and return parsed codeSample structs. Add unit tests in readme_test.go. For googleapis#6515
Define errEmptyDir sentinel error and use errors.Is assertion in error test cases.
…feat/java-extract-samples
JoeWang1127
reviewed
Jun 29, 2026
JoeWang1127
approved these changes
Jun 30, 2026
quirogas
pushed a commit
that referenced
this pull request
Jul 1, 2026
🤖 I have created a release *beep* *boop* --- ## [0.24.0](v0.23.0...v0.24.0) (2026-07-01) ### Features * **add:** handle Release Please config for google-cloud-node ([#6569](#6569)) ([1f8ee00](1f8ee00)) * **internal/librarian/java:** add code snippet extraction helpers for README rendering ([#6593](#6593)) ([96f6925](96f6925)), closes [#6515](#6515) * **internal/librarian/java:** add extractSamples for README generation ([#6578](#6578)) ([b5e3d45](b5e3d45)), closes [#6515](#6515) * **internal/librarian/nodejs:** add metadata_name_override and name_pretty_override support ([#6603](#6603)) ([3f6cfed](3f6cfed)), closes [#6453](#6453) * **internal/librarian:** add debug command with env subcommand ([#6576](#6576)) ([027103b](027103b)), closes [#6374](#6374) * **internal/librarian:** populate Java Maven coordinates from defaults ([#6554](#6554)) ([accb8ad](accb8ad)), closes [#6513](#6513) * **librarian/swift:** use discovery config ([#6604](#6604)) ([5a44ed7](5a44ed7)) * **sidekick/discovery:** signatures without path params ([#6588](#6588)) ([bb40e83](bb40e83)) ### Bug Fixes * **internal/librarian/java:** exclude google-cloud-bom and libraries-bom when generating gapic-libraries-bom/pom.xml ([#6601](#6601)) ([b8e50a5](b8e50a5)) * **internal/serviceconfig:** normalize transport name for Java repo-metadata ([#6582](#6582)) ([e20f77a](e20f77a)) * **sdk.yaml:** allow rust for many non-cloud apis ([#6598](#6598)) ([0efb6e7](0efb6e7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extractSamples main function to locate Java sample files and return parsed codeSample structs. Add unit tests in readme_test.go.
For #6515