Skip to content

java: move known group id mapping into config default section #6513

Description

@zhumin8

When adding new libraries, java currently have these hardcoded known group ids other than com.google.cloud:

switch {
case strings.HasPrefix(apiPath, "google/shopping/"):
return setNonCloudMavenDefaults(lib, "com.google.shopping")
case strings.HasPrefix(apiPath, "google/maps/"):
return setNonCloudMavenDefaults(lib, "com.google.maps")
case strings.HasPrefix(apiPath, "google/ads/"):
return setNonCloudMavenDefaults(lib, "com.google.api-ads")
}

We should convert these into config in the defaults for java:

Java *JavaDefault `yaml:"java,omitempty"`

Preserve the mapping from API path to relevant group id.

This approach has benefits that:

  • Supported group ids are visible from config
  • When adding new group ids in the future, this is configurable and no changes to librarian needed

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions