Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't edit current when changing docks v2 #91168

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Apr 25, 2024

Made the edit(nullptr) in NOTIFICATION_PREDELETE not run when exiting, since it doesn't need to clean up anything if exiting.
The object was apparently freed but not null, causing a crash on some platforms.

Needs testing on Linux and macOS to make sure #90816 (comment) doesn't happen.

Edit: made sure it works when there is no EditorNode, like in dotnet glue binding.

@kitbdev kitbdev requested a review from a team as a code owner April 25, 2024 16:44
@KoBeWi KoBeWi added this to the 4.3 milestone Apr 25, 2024
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically same as #90816, but with a safeguard against exit crash.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine on Linux.

@akien-mga akien-mga merged commit bf00e1e into godotengine:master Apr 30, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggling distraction-free mode selects (or opens) a fixed script in the script list
3 participants