-
-
Notifications
You must be signed in to change notification settings - Fork 20.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Godot freezes when trying to close project after first open #91520
Comments
Thanks for the report. Confirmed on Linux. Stacktrace:
|
On Windows, I see a warning that is related to the crash, but it isn't the same, so it needs testing. Is it a crash or a freeze or both? If it crashes when using |
I've seen it both crash and freeze when using The issue I see most consistently is freezing. |
I built #91538 and tested it, but it does not fix the freezing issue with Perhaps I need to bisect this for you when I get time? |
v4.3.dev.custom_build [55afb5b] |
After trying multiple times, I managed to get it to freeze on Windows. godot/editor/editor_resource_preview.cpp Lines 524 to 527 in e62ca29
This is in It looks like it is two separate issues. When it freezes it does so before anything can even be deleted, and when it crashes is happens during finalize when everything is being deleted as seen in the stacktrace above. I found these issues about the freeze that look similar: |
I can confirm the freeze from above comment, #91168 is unrelated. |
This comment was marked as off-topic.
This comment was marked as off-topic.
git bisect645be5c is the first bad commit
core/templates/command_queue_mt.cpp | 29 --------------- |
Every so often, even on a "bad" build, it doesn't freeze. It seems more consistent on some systems than others. So it can be hard to nail down. I thought it wasn't happening on anything besides Windows, but that was just my "luck" I think. I'm mostly testing on Windows. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Freeze confirmed on MacOSGodot v4.3.dev (645be5c) - macOS 14.4.1 - Vulkan (Forward+) - integrated Apple M2 - Apple M2 (8 Threads) Update: Also confirmed with: |
My current theory is that the crash fixed by #91168 was hiding the freeze on MacOS and Linux, but now that it is fixed, this freeze should be easier to trigger. |
@chrisl8 Could you give a refresh on the exact steps you use to reproduce the issue in latest I tried a few times with the GDQuest TPS demo, using both |
The freeze is not consistent on Linux, but it happens. It is much more consistent for me on Windows, nearly 100%, and pretty close to that on MacOS. I just tried this again just now on Linux and it worked fine 3 times in a row and froze on the fourth try. First just to be clear on how I'm building, in case it matters:
Then do this
To repeat the process quickly to try again to trigger the freeze:
I'm not sure if it only freezes on a fresh clone, or if the freeze is just inconsistent enough that when I tried only wiping the The process on Windows is similar, in short:
|
I've been able to reproduce it and I'm working on a fix. |
Tested versions
Reproducible In
Not Reproducible In
System information
#1
SMP PREEMPT_DYNAMIC Wed Apr 10 20:11:08 UTC 2024 - X11 - Vulkan (Forward+) - integrated Intel(R) UHD Graphics 620 (KBL GT2) () - Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz (8 Threads)Issue description
After opening the project for the first time (no
.godot
folder exists and no imports done), attempting to close the editor fails with the Godot engine freezing.Subsequent opening and closing of the project work.
Steps to reproduce
Clone the GDQuest Third-Person Shooter demo
Ensure there is no
.godot
folder.Run the editor with the
--import
flag.or
Open it in the editor
Wait for it to finish importing
Attempt to close the editor
The game is playable, but closing the editor just freezes.
The
--import
option is quicker to test.The only way I can make this crash/freeze consistently is to delete the folder and clone the project again.
Just deleting the
.godot
folder isn't enough, it usually does not crash on subsequent runs even if I do.Minimal reproduction project (MRP)
Use the GDQuest Third-Person Shooter demo
The text was updated successfully, but these errors were encountered: