Toggling distraction-free mode selects (or opens) a fixed script in the script list

[mieldepoche]

Tested versions

• does not happen in 4.3 dev 5
• happens in v4.3.dev.custom_build [578d937]

System information

linux

Issue description

• when toggling distraction free mode, a previously opened script is automatically re-opened

  • it happens independently of the number of opened scripts

• if deleted, it reopens anyway as an unsaved script

• in the clip below, I create a new script and toggle distraction free mode after closing the script: notice how it gets automatically re-openened. Note that I use a shortcut to close the script, which is why it happens quickly.

simplescreenrecorder-2024-04-14_12.47.00.mp4

Steps to reproduce

• create a script and open it, and close it
• toggle distraction free mode
• notice how the script opens automatically

Minimal reproduction project (MRP)

any

[kitbdev]

• Probably introduced in Refactor and fix issues in Editor Dock Manager #88003.

It unified all methods that affect docks, so toggling distraction free mode now calls EditorNode::get_singleton()->edit_current();, which causes this behavior. Before, some methods called edit_current and some didn't, so I'm not sure if it's necessary.

So, should changing docks not call edit_current or should edit_current be changed?

[KoBeWi]

Related:

godot.windows.editor.dev.x86_64_damBvJ8CB5.mp4

After you created a script, clicking any dock will open script editor. Extremely annoying.

[akien-mga]

Reopening as #90816 was reverted due to a crash.