Improve UX when saving newer files on disk

[adamscott]

Makes sure that people really understand the actions available when trying to save a file that is newer on disk than in the editor.

Before	After

Took inspiration from these prompts:

Special thanks to Therron Keen on Twitter for flagging this issue.

[JoNax97]

Are we sure we're not changing the meaning of each button here?

In the old dialog, the center button keeps the changes from disk, and the right button discards them.

But with the new dialog, the wording used makes it look like both options will discard the changes from disk.

[adamscott]

@JoNax97 I just checked out LibreOffice example in English (instead of French).

So, how about this?

[JoNax97]

I think it's more confusing than it needs to be. I will try to explain the way I reason about the wording, let me know if I'm unclear.

The dialog's subject is the external changes on disk.

But then the buttons introduce the new concept of "local changes" and the user has to reason backwards to understand what will happen to the main subject of the dialog, the changes on disk.

I'd propose something like:

The following files have been changed externally and differ from the local changes made by Godot.
<list of files here>

What do you want to do? 

Keep local changes | Keep external changes | Cancel

[ajreckof]

This is clearly better then what was proposed at the start as it explicit what is discarded is the local changes.

I think it's more confusing than it needs to be. I will try to explain the way I reason about the wording, let me know if I'm unclear.

The dialog's subject is the external changes on disk.

But then the buttons introduce the new concept of "local changes" and the user has to reason backwards to understand what will happen to the main subject of the dialog, the changes on disk.

I'd propose something like:

The following files have been changed externally and differ from the local changes made by Godot.
<list of files here>

What do you want to do? 

Keep local changes | Keep external changes | Cancel

I prefer adam last propositions of buttons but I feel this is really good : "The following files have been changed externally and differ from the local changes made by Godot."

[adamscott]

@JoNax97 The thing is that dialog actually saves/overwrites the content of the newer files. So, your buttons proposition don't reflect that.

[ajreckof]

Apparently there was a PR that was lost to the limbo #57062 and a proposal associated godotengine/godot-proposals#3456 😂 I think the PR could be closed in favor of this one but maybe there are interesting discussion there.

[akien-mga]

The discussion stalled but I think this is already a good intermediate step to improve the UX of this dialog. We can iterate further if someone comes up with a better design.

[akien-mga]

Thanks!