Rename buttons in disk_changed dialog

[wachtel1]

"The following files are newer on disk" dialog buttons:
Resave → Save Local Changes
Reload → Reload From Disk (Discard Local Changes)
Cancel → Do Nothing

Bugsquad edit: This closes godotengine/godot-proposals#3456.

[akien-mga]

Can you post a screenshot?

I'm afraid this makes quite lengthy buttons, even more so with some translations where sentences are typically longer than English (French, German).

[KoBeWi]

I think the "(Discard Local Changes)" part is not necessary, but the dialog is big enough:

[akien-mga]

Maybe it can be shortened to "Reload (Discard Local Changes)"?

The proposal also had interesting suggestions to reword the intro paragraph, which I think would be good to take into account to make this even more explicit. The buttons should be terse, but the paragraph in a huge window can be a bit more detailed.

In the proposal you also mentioned changing the dialog title, which I think would make sense.

[wachtel1]

Sorry for leaving this unattended for so long. I can't install proper C++ tooling on my machine, so building from the source is not available for me right now.

Maybe like this?

Title:

Files Have Been Changed

Text:

The following files currently opened have changes made by an external program.
Do you want to save changes from the Godot editor or reload the files from the disk and discard them?
This action can't be undone.

Buttons:

Save Local Changes
Reload (Discard Local Changes)
Do Nothing

[akien-mga]

Sounds good to me, maybe just a tiny edit to the text: discard them -> discard changes (since "them" can refer to "files" and not "changes" in that sentence).

For the title, maybe "Files Changed on Disk"?

[JoNax97]

This can probably be closed in favor of #90660

[AThousandShips]

Superseded by:

• Improve UX when saving newer files on disk #90660

If any further changes are desired please open a new PR with those changes separated

Thank you for your contribution nonetheless!