Tiny paddings in popup windows

[passivestar]

Tested versions

Reproducible in 4.2.1 and 4.3

System information

macOS 14.2.1 - Vulkan (Forward+) - integrated Apple M1 Max - Apple M1 Max (10 Threads)

Issue description

There's basically no space around popup window content on macOS no matter what editor settings I try, this is the default theme:

This is on windows:

The conversation about this started here

P.S. The default padding could also be increased by ~50%, because even on windows it look a bit too packed

Steps to reproduce

N/A

Minimal reproduction project (MRP)

N/A

[Calinou]

• Related to PopupMenu horizontal margins in the editor theme became too low since 4.3.dev3 #89697.

[akien-mga]

CC @bruvzg

[bruvzg]

I can't see any difference in the padding on macOS and Windows. What's your editor scale and macOS screen scale?

[passivestar]

I can't see any difference in the padding on macOS and Windows. What's your editor scale and macOS screen scale?

Default system screen scale, 16 inch macbook (3456x2234), in Godot I usually use 1.6 but it doesn't look any different at 2.0 (which is the default)

[passivestar]

I just noticed @adamscott doesn't have paddings in his popups too: #90660

They need more space:

So this issue isn't strictly macOS-specific

[coppolaemilio]

@adamscott and @passivestar are you using a custom theme at all? Does this happen also in the default one?

[passivestar]

@coppolaemilio we do but I have the same problem with the default theme (the first screenshot I attached on top is using the default one). We both seem to be using a high dpi display though

Here's the default theme:

Same 4 pixels:

[coppolaemilio]

So the paddings might not be getting multiplied by the rendering scale 🤔

[passivestar]

So the paddings might not be getting multiplied by the rendering scale 🤔

Probably yes

But it'd also not be enough. Multiplying 4px by my editor scale 1.5 would give me 6px which is practically the same

I had to lift by 12 pixels here (for a total of 16) for it to look not scuffed:

For reference: both Editor Settings and Project Settings windows have exactly that - 16px of space on my screen. I suggest using the same value for all of the popups