-
-
Notifications
You must be signed in to change notification settings - Fork 20.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix packed scene translation parser missing strings. #89286
Conversation
98bff39
to
a5eb762
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might even make sense to parse the whole instanced scene too
I would recommend against that, since it could lead to parsing of unwanted strings. 😉
Overall, nice job!
BTW the same could happen with the inclusion of all |
a5eb762
to
342d061
Compare
342d061
to
8446084
Compare
Thanks! And congrats for your first merged Godot contribution 🎉 |
This is my attempt to fix the POT generator missing strings.
(fixes Localization POT generation does not regognize text on instanced nodes. #74194, probably fixes POT generation with saved scenes loaded from another scene doesn't work #79144)
MenuButton
andOptionButton
case, as it's attempting to parse the old 3.x scene format.popup/item_0/text
property of the nodes with popup menus.(fixes Menu- and OptionButton item text strings don't get included in POT generation #88017)
I'm planning to add the lookup and exclude properties in the project settings, but i don't know how to do that yet.
This is my first time really working with c++ so i have no idea really what im doing.
It might be that the variable names im using are wrong.
I ported this code from a custom translation parser i made in gdscript.