Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packed scene translation parser missing strings. #89286

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Kiisu-Master
Copy link
Contributor

@Kiisu-Master Kiisu-Master commented Mar 8, 2024

This is my attempt to fix the POT generator missing strings.

I'm planning to add the lookup and exclude properties in the project settings, but i don't know how to do that yet.
This is my first time really working with c++ so i have no idea really what im doing.
It might be that the variable names im using are wrong.
I ported this code from a custom translation parser i made in gdscript.

Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might even make sense to parse the whole instanced scene too

I would recommend against that, since it could lead to parsing of unwanted strings. 😉

Overall, nice job!

@Kiisu-Master
Copy link
Contributor Author

It might even make sense to parse the whole instanced scene too

I would recommend against that, since it could lead to parsing of unwanted strings. 😉

Overall, nice job!

BTW the same could happen with the inclusion of all *_text properties. It will include more strings from nodes inheriting AcceptDialog, but also user created nodes which might use this name ending for other purposes. I know there is some properties that end with _text that arent strings, but that's taken care of with the type check. I hope it doesn't cause problems.

@akien-mga akien-mga merged commit 47941d4 into godotengine:master Mar 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Calinou Calinou added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:gui
Projects
None yet
5 participants