We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.stable.official [92bee43]
Arch Linux
Localization POT generation does not regognize text on instanced nodes.
localization_instances.zip
The text was updated successfully, but these errors were encountered:
Issue might be that instanced button has no type when queried with SceneState.get_node_type()
SceneState.get_node_type()
The parser checks with the type if the node is translatable
godot/editor/plugins/packed_scene_translation_parser_plugin.cpp
Lines 54 to 58 in 1c1524a
Tested if instances behave differently with the checks used in the parser (only in editor though):
func _ready(): var state = ResourceLoader.load("res://main.tscn").get_state() var nodecount = state.get_node_count() for i in range(0, nodecount): var nodetype = state.get_node_type(i) print(state.get_node_name(i), ", type: ", nodetype, ", child of Control: ", ClassDB.is_parent_class(nodetype, "Control"), ", child of Window: ", ClassDB.is_parent_class(nodetype, "Window")) var propcount = state.get_node_property_count(i) for j in range(0, propcount): print(state.get_node_property_name(i, j), " ", state.get_node_property_value(i, j))
outputs:
... Button, type: Button, child of Control: true, child of Window: false offset_right 8 offset_bottom 8 text NORMAL_BTN btn_instance, type: , child of Control: false, child of Window: false offset_top 45 offset_bottom 188 text INSTANCED_BTN
Sorry, something went wrong.
instantiated
.tscn
I'm also facing this issue. Any updates on this?
Successfully merging a pull request may close this issue.
Godot version
v4.0.stable.official [92bee43]
System information
Arch Linux
Issue description
Localization POT generation does not regognize text on instanced nodes.
Steps to reproduce
Minimal reproduction project
localization_instances.zip
The text was updated successfully, but these errors were encountered: