Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clipboard image data get/set methods #76603

Closed
wants to merge 249 commits into from
Closed

Add clipboard image data get/set methods #76603

wants to merge 249 commits into from

Conversation

radzo73
Copy link
Contributor

@radzo73 radzo73 commented Apr 30, 2023 •
edited
Loading

Closes godotengine/godot-proposals#2949.
TODO:

  • Image clipboard_get_image
  • void clipboard_set_image (Image img)

MewPurPur and others added 25 commits January 30, 2023 14:04
@MewPurPur
Fix popup position of color picker
040e258
@KoBeWi
Add info label to TileMap editor
979b53a
@smosages
Move ShaderWarning definitions into rendering_server
786ad51
@dalexeev
Fix draw_multiline_colors() for width < 0
ba985ec
@BastiaanOlij
Fix incorrect HTC action map entries
e15358d
@Sauermann
Move call of push_unhandled_input from Window to Viewport
8836f21 
This solves the problem, that mouse events get sent to SubViewports
even if they are outside of the visible area of the SubViewport.

This changes makes SubViewportContainer::unhandled_input redundand.
Shortcut Events now need to be distributed via push_input, in order for
them to be able to reach SubViewports.
@Chaosus
Fix shader uniform groups to prevent it sorting in alphabet order
8ea4ace
@BastiaanOlij
Expose viewports render targer RID
ab60d3b
@KoBeWi
Close built-in shaders when closing scene
aaf02ec
@RandomShaper
Allow creation of rendering buffers at any time
d4c46f1
@rburing
PhysicsDirectBodyState3D: report contact points using global coordinates
15b8cb9 
Also update the documentation to reflect this in both 2D and 3D.
@ChibiDenDen
Add shader cache to gles3
4adbfcf
@dalexeev
Fix multiline items drawing in Tree
865d6f5
@AThousandShips
Fix size error in BitMap.opaque_to_polygons
249784e 
Previous estimate of upper limit on size was incorrect
@Tetane
Use a SubViewport for CanvasItem inspector preview
d3792a2
@KoBeWi
Improve and document PackedDataContainer
c08e96e
@clayjohn
Fix compatibility breakage from adding NoiseTexture3D
ccff245 
Also optimize some of the Noise methods
@timothyqiu
Allow EditorInspector to change its property name style when necessary
d24ee55 
Previously, an EditorInspector's property name can only be set from
outside. Inspectors used for settings needs to respond to changes in
editor settings. So a few boilerplate code is almost always needed,
including watching for a certain editor setting in `_notification()`.

This commit adds a `set_use_settings_style()` function to tell the
inspector to watch for editor settings changes on its own.
@Black-Cat @rburing
Fix precision in physics supports generation
d710af2 
Lower threshold for dot was (1.0 - threshold) which is incorrect.
Patch changes it to correct version sqrt(1.0 - threshold * threshold)

Co-authored-by: Ricardo Buring <[email protected]>
@ChibiDenDen
Fix gles3 rendering on android studio emulator
5956aa1 
Use a temporary framebuffer for screen copy from rendertarget to screen.

This solves GLES3 rendering in android studio emulator (before this change there is just a black screen)

Based on discussion in:
godotengine#74828
@stmSi
Added note to used set_deferred while setting scroll values in _ready…
83626ab 
… function.
@Maran23
Expose horizontal/vertical custom_step as editor property for the Scr…
29358da 
…ollContainer
@Calinou
Document high performance cost of turbulence in ParticleProcessMaterial
f107594 
- Mention that GPUParticlesAttractorVectorField3D can be used as an
  alternative to turbulence in 3D.
@radzo73
Clipboard has/get image methods
05402df 
A rebase of godotengine#63826
@radzo73
Things I didn't catch before test compiling
f3d911f 
boy am I glad I test things
@radzo73 radzo73 requested review from a team as code owners April 30, 2023 01:55
@radzo73 radzo73 requested review from a team as code owners May 11, 2023 19:31
@radzo73 radzo73 changed the title Added clipboard has/image get methods Add raw clipboard data get/set methods May 11, 2023
@radzo73 radzo73 changed the title Add raw clipboard data get/set methods Add clipboard image data get/set methods May 11, 2023
@radzo73
Copy link
Contributor Author

radzo73 commented May 11, 2023

System-exclusive problems that I have to deal with when encoding/decoding to Godot's Image:

  • Windows requires a clipboard format when getting/setting data. Most likely format for image purposes is CF_DIB.
  • MacOS' clipboard primarily uses two image formats, PNG and TIFF
  • iOS can easily get all images on the clipboard, but main image formats will be kUTTypePNG and kUTTypeJPEG.
  • X11, Android, Web...I have no idea. (there's also the Wayland port to worry about)

@radzo73
Copy link
Contributor Author

radzo73 commented May 11, 2023

Closing in favor of a fresh fork
(because I didn't change those 490 files, Git)

@radzo73 radzo73 closed this May 11, 2023
@aaronfranke
Copy link
Member

@radzo73 In the future, you should open a pull request from a separate branch (radzo73:something), not from master (radzo73:master). This would prevent the issues you had.

@radzo73 radzo73 mentioned this pull request Jul 16, 2023
Closed
@YuriSizov YuriSizov removed this from the 4.x milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg left review comments

Assignees
No one assigned
Labels
archived feature proposal topic:porting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow getting image data from the system clipboard