Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set instancing flags when using GPUParticles in OpenGL renderer #72853

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

clayjohn
Copy link
Member

@clayjohn clayjohn commented Feb 7, 2023

Fixes: #72847

#72681 partially fixed #72847, but it missed setting the flags for GPUParticles. This PR adds the flags.

GPUParticles always read color and custom_data from the particle buffer, so the flags always need to be set

@clayjohn clayjohn added this to the 4.0 milestone Feb 7, 2023
@clayjohn clayjohn requested a review from a team as a code owner February 7, 2023 18:47
@akien-mga akien-mga merged commit c6d6c01 into godotengine:master Feb 8, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPUParticles2D color attribute not working in GLES3 (compatibility)
2 participants