Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGL: GPUParticles2D with Color alpha set to 0 are not transparent #72882

Closed
Tracked by #66458
JonqsGames opened this issue Feb 8, 2023 · 4 comments · Fixed by #72914
Closed
Tracked by #66458

OpenGL: GPUParticles2D with Color alpha set to 0 are not transparent #72882

JonqsGames opened this issue Feb 8, 2023 · 4 comments · Fixed by #72914
Labels
bug topic:particles topic:rendering topic:3d
Milestone
4.0

Comments

@JonqsGames
Copy link
Contributor

JonqsGames commented Feb 8, 2023 •
edited
Loading

Godot version

4.0.dev (8843d9a)

System information

Windows 10

Issue description

#72853 fixed #72847
But with the same setup and setting the alpha to 0, particles are still visible.

Steps to reproduce

Reproduce #72847
Set alpha to 0

Minimal reproduction project

MRP from #72847
@JonqsGames JonqsGames changed the title Particles2D with Color alpha set to 0 are not transparent GPUParticles2D with Color alpha set to 0 are not transparent Feb 8, 2023
@Calinou
Copy link
Member

Calinou commented Feb 8, 2023

Can you reproduce this when using the Forward+ or Mobile rendering methods, or only Compatibility?

@JonqsGames
Copy link
Contributor Author

@Calinou only in Compatibility
Works normally with other renderer.

@Calinou Calinou changed the title GPUParticles2D with Color alpha set to 0 are not transparent OpenGL: GPUParticles2D with Color alpha set to 0 are not transparent Feb 8, 2023
@Calinou Calinou mentioned this issue Feb 8, 2023
Open
@Calinou Calinou added this to the 4.0 milestone Feb 8, 2023
@JonqsGames
Copy link
Contributor Author

Did some more test around this and i think the issue is with 0 value in any channel, i suspect the issue is in unpackHalf2x16

@JonqsGames
Copy link
Contributor Author

JonqsGames commented Feb 8, 2023 •
edited
Loading

I'm working on a refactor of float2half and half2float the solution used currently is not working for some value (exposant == 0, truncated mantissa...) @clayjohn

This was referenced Feb 8, 2023
Closed
Merged
@Maran23 Maran23 mentioned this issue Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:particles topic:rendering topic:3d
Projects
None yet
Milestone
4.0
2 participants
@Calinou @JonqsGames