Windows icon export improvements. #68828
Merged
+152
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Nov 18, 2022
|
This could be worth backporting to 3.6 (and maybe 3.5.2) as the blurry icon issue is a regression in 3.5. |
Regenerate Windows icon on export to ensure correct icon size order. Add support for using PNG/WebP/SVG files as an icon for Windows exports. Allow using WebP/SVG files as icon for macOS exports. Add option to select generated icons interpolation, and set default interpolation to Lanczos.
bruvzg
force-pushed
the
win_regen_icon
branch
from
781bb75
to
ac0ed9c
Compare
|
Added missing file extensions for the "console wrapper icon", and an option to select interpolation mode for the generated icons, and set default interpolation to Lanczos for more smooth results.
I'll do a 3.x backport next Monday. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64073
Now icons won't be blurry regardless of size order in the icon, exporter will reorder it, remove unnecessary sizes and warn is some are missing.
It's also possible to auto generate icon from any
Image(also added WebP / SVG for macOS exported, since it should be able to generate icon from anyImageas well).Note: Order of the sizes in the default icon used by the export template must always match order in the
static const uint8_t icon_size[]array, if the default icon is updated (e.g., reverted to compressed version), this array should be updated as well.