-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changing_application_icon_for_windows.rst #8563
Conversation
The icons appear blurry if the order of the sizes in the commands are reversed.
I made a test project in 4.2.1 and exported it with an ICO file that was created with the original size order, and with the new order. I'm not seeing any visual difference between the two on Windows 11 in the taskbar, or in file explorer with the extra large icons option. I will not be able to test win 10 until I'm back from the holidays. did you use godoticon to change the icon instead of rcedit? |
@skyace65 You didn't have to do any of that. This is additionally done to keep the order consistent after generation. The inverse order can be seen using other tools. We all got the result here: godotengine/godot#64073 (comment) Even if you check the order of the generated ico on the other versions, the result is still the same using the old docs. |
I don't understand why you want to change the size order in the docs when there are merged PR's for the 3.x and 4.x branch that fixed this issue. |
I just realized something about my first post. I was talking about the command and order of the images changing not the blurriness being fixed (you can see this when you open those .ico files in GIMP). |
Source icon size order should not matter, it is rearranged to have correct order on export anyway, see godotengine/godot#68828 and godotengine/godot#68858. |
I think it's rcedit bug, it's not replacing all icon related resources so it should have the same order as the default icon. |
Alright, @bruvzg that's enough for today. Really appreciate that PR. I need to do a check on rcedit myself. |
Closing as per the above discussion. Thanks for taking the time to contribute! |
Just in case anyone was wondering (I do regret not closing this pull request and entire matter sooner), the latest state seems to be that rcedit is probably going to be completely dropped. godotengine/godot#75950 (comment) |
The icons appear blurry if the order of the sizes in the commands are reversed. This happened in v3.5.stable, but I did a quick check (correct me if I'm wrong) and I think there has not been much change since then.
Related to godotengine/godot#64073.
I'll add some tips to refresh the icon cache and thumbnails in another pull request.