Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LinearDepth calculation in the Visual Shader node for GLES3 #65160

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

paddy-exe
Copy link
Contributor

@paddy-exe paddy-exe commented Aug 31, 2022

This change will calculate the depth ndc differently for GLES3 and Vulkan as described in here:
stable:
https://docs.godotengine.org/en/stable/tutorials/shaders/advanced_postprocessing.html
godot 4 with vulkan:
https://docs.godotengine.org/en/latest/tutorials/shaders/advanced_postprocessing.html

Original PR: #64248

@paddy-exe paddy-exe requested a review from a team as a code owner August 31, 2022 19:01
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Chaosus Chaosus merged commit a5db03e into godotengine:master Aug 31, 2022
@Chaosus
Copy link
Member

Chaosus commented Aug 31, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants