Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AudioEffectCapture #45593

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Jan 30, 2021

AudioEffectCapture allows access to the microphone and other audio on an audio bus in real-time.

Implementation of the updated proposal at godotengine/godot-proposals#2013

Thanks to @fire and @Faless for their input and help.

Bugsquad edit:

Fixes: godotengine/godot-proposals#2013, godotengine/godot-proposals#399, #35402

servers/audio/effects/audio_effect_capture.h Outdated Show resolved Hide resolved
servers/audio/effects/audio_effect_capture.cpp Outdated Show resolved Hide resolved
servers/audio/effects/audio_effect_capture.cpp Outdated Show resolved Hide resolved
servers/audio/effects/audio_effect_capture.cpp Outdated Show resolved Hide resolved
servers/audio/effects/audio_effect_capture.cpp Outdated Show resolved Hide resolved
@lyuma lyuma requested a review from a team as a code owner February 2, 2021 01:44
<return type="int">
</return>
<description>
Returns the number of frames available to read using [method get_buffer]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Returns the number of frames available to read using [method get_buffer]
Returns the number of frames available to read using [method get_buffer].

<return type="PackedVector2Array">
</return>
<argument index="0" name="frames" type="int">
Number of audio frames to return.
Copy link
Member

@akien-mga akien-mga Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arguments can't be documented this way, running doctool would remove it. Argument-specific details can be given in the <description> (though here I think the description is clear enough about what [code]frames[/code] is).

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from last documentation nitpicks, looks good to me 👍

AudioEffectCapture allows access to the microphone and other audio on an audio bus in real-time.

Co-Authored-By: K. S. Ernest (iFire) Lee <[email protected]>
@akien-mga akien-mga merged commit cc95e2c into godotengine:master Feb 2, 2021
@akien-mga
Copy link
Member

Thanks!

@FilipaSilva05
Copy link

Hi. Great news! Will this be available in 3.2?

@lyuma
Copy link
Contributor Author

lyuma commented Feb 22, 2021

Hi. Great news! Will this be available in 3.2?

3.2.4 is still in release candidate stage, so it's up to Remi if new functionality can still be added.

Anyway, I filed pull request #46304

@paulicka
Copy link

Why doesn't this support signals, and instead require every user to poll?

@GeorgeS2019
Copy link

@paulicka I cited your feedback here.

@lyuma lyuma deleted the audio_effect_capture branch May 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioEffectCapture: attach a scriptable audio processing pipeline to a bus.
7 participants