Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio effect stream #399

Closed
fire opened this issue Jan 21, 2020 · 0 comments
Closed

Audio effect stream #399

fire opened this issue Jan 21, 2020 · 0 comments

Comments

@fire
Copy link
Member

fire commented Jan 21, 2020

Describe the project you are working on:

Unreleased game.

Describe the problem or limitation you are having in your project:

VOIP support is crucial to the game's use.

Describe how this feature / enhancement will help you overcome this problem or limitation:

The previous pull requests by Saracen have been reverted.

godotengine/godot#30468 (comment)

The goal is to get specific sized chunks from a ring buffer saving the current effect.

The effect streams the current bus so that we get either zero or equally sized vector of floats in left / right format. This allows something like opus to have same sized buffers to use as input for VOIP.

This is an audio server implementation.

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:

None.

Describe implementation detail for your proposal (in code), if possible:

See description. See pull request godotengine/godot#35402

If this enhancement will not be used often, can it be worked around with a few lines of script?:

Effects can only be written in the core engine. The script approach causes stuttering.

Is there a reason why this should be core and not an add-on in the asset library?:

Effects can only be written in the core engine.

@fire fire changed the title Audio effect stream buffer [WIP] Audio effect stream buffer Jan 21, 2020
@fire fire changed the title [WIP] Audio effect stream buffer Audio effect stream buffer Jan 21, 2020
@fire fire changed the title Audio effect stream buffer Audio effect stream Jan 21, 2020
@fire fire closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants