[3.2] [iOS] iOS Plugins Migration #45336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 26, 2021
Comment on lines
-190
to
-191
| "-framework", | ||
| "OpenGLES", |
There was a problem hiding this comment.
Isn't this still relevant to keep? Or is it added somewhere else?
There was a problem hiding this comment.
Since iOS export was previously updated to support modules with -fmodules and -fcxx-modules flags there should be no need to manually set system frameworks for linkage. Should keep build instructions more clear.
But I can revert this change if keeping them is better
There was a problem hiding this comment.
But I can revert this change if keeping them is better
No I trust you there, I don't have experience with this. I just asked in case this was overlooked among other frameworks which might have been needed for the plugins only.
akien-mga
approved these changes
Jan 26, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #45252 for
3,2branch.Plugins are now located at https://github.com/godotengine/godot-ios-plugins.
Godot 3.2.4 beta 6 plugins (
.aversion with bothdebugandreleaseconfigurations) are available here: https://github.com/godotengine/godot-ios-plugins/releases/tag/3.2.4_beta_6