Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update android gradle plugins versions #43178

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Update android gradle plugins versions #43178

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aff7cf4
Update the gradle plugins
m4gr3d Oct 28, 2020
edf762f
Add a separate `nativeSrcsConfigs` module to handle Android Studio co…
m4gr3d Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions platform/android/java/app/config.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
ext.versions = [
androidGradlePlugin: '3.5.3',
androidGradlePlugin: '4.1.0',
compileSdk : 29,
minSdk : 18,
targetSdk : 29,
buildTools : '29.0.3',
buildTools : '30.0.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super knowledgeable on how buildTools relate to the target SDK, but do we want to bump compileSdk and targetSdk to 30 eventually too?

And that's likely something we'll want to do in 3.2 too as usually Google makes this a requirement for new apps at some point. Judging by previous years, that would be from ~August 2021 (not announced yet): https://support.google.com/googleplay/android-developer/answer/113469#targetsdk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to resolve #38913 before we can bump the targetSdk and compileSdk as the current workaround we're using is ignored when targeting Android 11 (API level 30).

supportCoreUtils : '1.0.0',
kotlinVersion : '1.3.61',
kotlinVersion : '1.4.10',
v4Support : '1.0.0'

]
Expand Down
2 changes: 2 additions & 0 deletions platform/android/java/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ org.gradle.jvmargs=-Xmx1536m
# This option should only be used with decoupled projects. More details, visit
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true

org.gradle.warning.mode=all
2 changes: 1 addition & 1 deletion platform/android/java/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5-all.zip