-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update android gradle plugins versions #43178
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
ext.versions = [ | ||
androidGradlePlugin: '3.5.3', | ||
androidGradlePlugin: '4.1.0', | ||
compileSdk : 29, | ||
minSdk : 18, | ||
targetSdk : 29, | ||
buildTools : '29.0.3', | ||
buildTools : '30.0.1', | ||
supportCoreUtils : '1.0.0', | ||
kotlinVersion : '1.3.61', | ||
v4Support : '1.0.0' | ||
kotlinVersion : '1.4.10', | ||
v4Support : '1.0.0', | ||
javaVersion : 1.8 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you know what's the state of Java 11 compatibility in the Android SDK / Studio? Our documentation still tells people to install specifically JDK 8 for But many Linux distros are finally leaving OpenJDK 1.8 behind and defaulting to JDK 11 LTS, so we'll need to support this somehow if we can. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @akien-mga I'll look into it. |
||
|
||
] | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<manifest package="org.godotengine.godot" /> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
## Native sources configs | ||
|
||
This is a non functional Android library used to provide Android Studio editor support to the Godot project native files. | ||
Nothing else should be added to this library. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
// Non functional android library used to provide Android Studio editor support to the project. | ||
plugins { | ||
id 'com.android.library' | ||
} | ||
|
||
android { | ||
compileSdkVersion versions.compileSdk | ||
buildToolsVersion versions.buildTools | ||
|
||
defaultConfig { | ||
minSdkVersion versions.minSdk | ||
targetSdkVersion versions.targetSdk | ||
} | ||
|
||
compileOptions { | ||
sourceCompatibility versions.javaVersion | ||
targetCompatibility versions.javaVersion | ||
} | ||
|
||
packagingOptions { | ||
exclude 'META-INF/LICENSE' | ||
exclude 'META-INF/NOTICE' | ||
|
||
// Should be uncommented for development purpose within Android Studio | ||
// doNotStrip '**/*.so' | ||
} | ||
|
||
sourceSets { | ||
main { | ||
manifest.srcFile 'AndroidManifest.xml' | ||
} | ||
} | ||
|
||
externalNativeBuild { | ||
cmake { | ||
path "CMakeLists.txt" | ||
} | ||
} | ||
|
||
libraryVariants.all { variant -> | ||
def buildType = variant.buildType.name.capitalize() | ||
|
||
def taskPrefix = "" | ||
if (project.path != ":") { | ||
taskPrefix = project.path + ":" | ||
} | ||
|
||
// Disable the externalNativeBuild* task as it would cause build failures since the cmake build | ||
// files is only setup for editing support. | ||
gradle.startParameter.excludedTaskNames += taskPrefix + "externalNativeBuild" + buildType | ||
} | ||
} | ||
|
||
dependencies {} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,4 @@ rootProject.name = "Godot" | |
|
||
include ':app' | ||
include ':lib' | ||
include ':nativeSrcsConfigs' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super knowledgeable on how
buildTools
relate to the target SDK, but do we want to bumpcompileSdk
andtargetSdk
to 30 eventually too?And that's likely something we'll want to do in
3.2
too as usually Google makes this a requirement for new apps at some point. Judging by previous years, that would be from ~August 2021 (not announced yet): https://support.google.com/googleplay/android-developer/answer/113469#targetsdkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to resolve #38913 before we can bump the
targetSdk
andcompileSdk
as the current workaround we're using is ignored when targeting Android 11 (API level 30).