Update android gradle plugins versions #43178
Conversation
…nstraints for native code editor support.
m4gr3d
added
platform:android
topic:buildsystem
cherrypick:3.x
| @@ -6,7 +6,8 @@ ext.versions = [ | |||
| buildTools : '30.0.1', | |||
| supportCoreUtils : '1.0.0', | |||
| kotlinVersion : '1.4.10', | |||
| v4Support : '1.0.0' | |||
| v4Support : '1.0.0', | |||
| javaVersion : 1.8 | |||
There was a problem hiding this comment.
Do you know what's the state of Java 11 compatibility in the Android SDK / Studio?
Our documentation still tells people to install specifically JDK 8 for jarsigner, as earlier and later versions seemed to be problematic, and I remember running into issues with newer Java when using sdkmanager.
But many Linux distros are finally leaving OpenJDK 1.8 behind and defaulting to JDK 11 LTS, so we'll need to support this somehow if we can.
There was a problem hiding this comment.
@akien-mga I'll look into it.
| compileSdk : 29, | ||
| minSdk : 18, | ||
| targetSdk : 29, | ||
| buildTools : '29.0.3', | ||
| buildTools : '30.0.1', |
There was a problem hiding this comment.
I'm not super knowledgeable on how buildTools relate to the target SDK, but do we want to bump compileSdk and targetSdk to 30 eventually too?
And that's likely something we'll want to do in 3.2 too as usually Google makes this a requirement for new apps at some point. Judging by previous years, that would be from ~August 2021 (not announced yet): https://support.google.com/googleplay/android-developer/answer/113469#targetsdk
There was a problem hiding this comment.
We need to resolve #38913 before we can bump the targetSdk and compileSdk as the current workaround we're using is ignored when targeting Android 11 (API level 30).
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
added
enhancement
and removed
cherrypick:3.x
|
@akien-mga Is there a separate |
|
@akien-mga Sounds good. I thought you had already done that step hence my confusion :) |
Bump the Android gradle plugins versions to the latest.
Android Studio 4.1+ seems to stop providing editor support for (and recognizing) Android libraries when they define an external native build whose root includes the library's directory.
As a workaround, I moved the external native build definition into a separate empty Android library. This does not affect the project structure since the external native build definition was added in the first place for Android Studio editor support (the actual native dependencies are handled by
scons).