-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple recent Bullet physics crashing issues. #41082
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 7, 2020
madmiraal
force-pushed
the
revert-39726
branch
from
September 14, 2020 10:08
427fb82
to
120cf1c
Compare
madmiraal
force-pushed
the
revert-39726
branch
from
September 16, 2020 06:37
120cf1c
to
119636a
Compare
Rebased following #42061. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40311
Fixes #40840
As elaborated on here and here, #39726 has caused multiple crashing issues (such as #40311 and #40840) which are not being fully resolved with #40252 (see comment) #40886 or #41067 (see comment) Furthermore, it did not solve #30027 for which it was created. Therefore this PR reverts #39726, which also requires reverting #40252.
Note: This PR also includes three additional commits:
Finally I've confirmed it does not revert the fix for #40506.