Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add call to Bullet pre_process() at start of dispatch_callbacks() #40886

Closed
wants to merge 1 commit into from
Closed

Add call to Bullet pre_process() at start of dispatch_callbacks() #40886

wants to merge 1 commit into from

Conversation

madmiraal
Copy link
Contributor

Also adds RigidBodyCollisionObjectBullet to flush queue when a shape reload is needed.

Fixes #40840.

@madmiraal
Add call to Bullet pre_process() at start of dispatch_callbacks(),
053721f 
and add RigidBodyCollisionObjectBullet to flush queue when a shape
reload is needed.
@AndreaCatania
Copy link
Contributor

Thanks for the PR. The function pre_process is made to be called just before the process starts for a rigid body. Is better if you call p_body->pre_process(); into the function test_body_motion.

https://github.com/godotengine/godot/blob/master/modules/bullet/space_bullet.cpp#L984

@AndreaCatania AndreaCatania added this to the 4.0 milestone Jul 31, 2020
@AndreaCatania AndreaCatania added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jul 31, 2020
@aaronfranke aaronfranke mentioned this pull request Aug 3, 2020
Closed
@madmiraal madmiraal mentioned this pull request Aug 5, 2020
Merged
@AndreaCatania AndreaCatania mentioned this pull request Aug 6, 2020
Closed
@madmiraal madmiraal mentioned this pull request Aug 6, 2020
Closed
@madmiraal
Copy link
Contributor Author

Superceed by #41082.

@madmiraal madmiraal closed this Aug 7, 2020
@madmiraal madmiraal deleted the fix-40840 branch August 7, 2020 11:19
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IhostVlad IhostVlad IhostVlad approved these changes

@AndreaCatania AndreaCatania Awaiting requested review from AndreaCatania

Assignees
No one assigned
Labels
archived bug crash topic:physics
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Runtime crash when calling KinematicBody3D.move_and_slide with Bullet physics
4 participants
@madmiraal @AndreaCatania @IhostVlad @akien-mga