Call reload_space_override_modificator() directly when processing a body entering or leaving an area. #40186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entering or leaving an area instead of adding it to the queue to be called during the next physics iteration.
|
The issue is due to a flush callback order. The areas should be flushed before the other collision bodies. I've few ideas to solve it without making the flush immediate. I'll do a PR or update this PR, soon. |
|
I've open this: #40252 |
|
Is this still relevant or fully superseded by #40252? |
|
Superseded by #40252. |
|
Closing as bullet was removed from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when processing a
RigidBodyentering or exiting anArea, the code to update the effect that anAreahas on aRigidBodyis not called directly, instead it is added to the queue to be processed in the next physics iteration.This PR ensures the code to update the effect an Area has on the
RigidBodyentering or exiting anAreais called as theRigidBodyenters or exits theAreaensuring its affect is felt immediately and not only in the next physics iteration.Improves #40127 which is caused by the effect an
Areahas on aRigidBodyonly being applied two physics frames later. This PR reduces it to one. The other is due to a physics iteration still being required to detect theRigidBodycolliding with theArea, but that is for another PR.