GDScript: Fix and simplify coroutine stack clearing#117053
Merged
Repiteo merged 1 commit intoMar 12, 2026
Merged
Conversation
akien-mga
approved these changes
Mar 12, 2026
Contributor
|
Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERROR: Parameter"_p"is null when running a script with aDictionaryvariable and twoawaits#117164.This PR simplifies coroutine stack clearing. When a coroutine resumed, the stack was previously stored in multiple
GDScriptFunctionStates (via theRef<GDScriptFunctionState> first_state;field).Now, previous
GDScriptFunctionStates are no longer held in memory. After a suspended function resumes, responsibility for the stack passes toGDScriptFunction::call(), which cleans it up at the end as usual.The
first_statefield was introduced in #19828. I made sure that this change doesn't reintroduce #19823:Before, it was
previous_state, introduced in #17291. I made sure that this change doesn't reintroduce #17280: