Skip to content

Fix bottom dock offsets and change Audio to EditorDock#113241

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:Audiock
Dec 3, 2025
Merged

Fix bottom dock offsets and change Audio to EditorDock#113241
Repiteo merged 1 commit into
godotengine:masterfrom
KoBeWi:Audiock

Conversation

@KoBeWi
Copy link
Copy Markdown
Member

@KoBeWi KoBeWi commented Nov 27, 2025

Part of #113024
Fixes #112616

The way #111499 was implemented is not compatible with the new bottom panel. Not all bottom docks are children of the bottom panel, and also EditorDocks are not being added to bottom_docks list, so the code required some changes. The offsets are now stored in a Dictionary, so layout saving is no longer dependent on what dock happens to be at the bottom.

#112616 is fixed by adding a default Audio size to the default layout and loading it on initial launch (similar to #113232 in its original form).

Comment thread editor/audio/editor_audio_buses.cpp Outdated
Comment thread editor/gui/editor_bottom_panel.cpp
Comment thread editor/gui/editor_bottom_panel.cpp
Comment thread editor/audio/editor_audio_buses.cpp Outdated
Copy link
Copy Markdown
Contributor

@lodetrick lodetrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error when starting up the editor:

ERROR: Couldn't find the given section "EditorNode" and key "bottom_panel_offsets", and no default was given.

I don't know if it was related but the audio offset was not updated either (even when loading from default)

Comment thread editor/audio/editor_audio_buses.cpp
@KoBeWi
Copy link
Copy Markdown
Member Author

KoBeWi commented Nov 28, 2025

The default Audio size is loaded only when initializing editor layout for the first time (i.e. the file was never saved in the project or was deleted).

@arkology
Copy link
Copy Markdown
Contributor

i.e. the file was never saved in the project or was deleted

What about not saving audio tab offset if its offset is 0? I think in this case "default" value will be loaded every time, right?

@KoBeWi
Copy link
Copy Markdown
Member Author

KoBeWi commented Nov 29, 2025

No

Copy link
Copy Markdown
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

The dock can't be moved to the side by design, but you can turn it into a floating window, which is useful to make it taller:

image

@Repiteo Repiteo merged commit fc8c494 into godotengine:master Dec 3, 2025
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Dec 3, 2025

Thanks!

@arkology
Copy link
Copy Markdown
Contributor

arkology commented Dec 3, 2025

Tested locally, it works as expected. Code looks good to me.

The dock can't be moved to the side by design, but you can turn it into a floating window, which is useful to make it taller:

image

If we talk about its size, then it can still be fitted into editor sides with some changes. The minimum width is limited by the top panel of this dock, and after reducing it (for quick testing, I just removed the text from all the buttons), the panel fits pretty well into the side panels.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audio tab makes bottom panel permanently bigger

6 participants