Fix bottom dock offsets and change Audio to EditorDock#113241
Merged
Conversation
18 tasks
lodetrick
reviewed
Nov 28, 2025
lodetrick
reviewed
Nov 28, 2025
Contributor
There was a problem hiding this comment.
I'm getting this error when starting up the editor:
ERROR: Couldn't find the given section "EditorNode" and key "bottom_panel_offsets", and no default was given.
I don't know if it was related but the audio offset was not updated either (even when loading from default)
Member
Author
|
The default Audio size is loaded only when initializing editor layout for the first time (i.e. the file was never saved in the project or was deleted). |
lodetrick
approved these changes
Nov 28, 2025
Contributor
What about not saving audio tab offset if its offset is 0? I think in this case "default" value will be loaded every time, right? |
Member
Author
|
No |
Calinou
approved these changes
Dec 2, 2025
Contributor
|
Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #113024
Fixes #112616
The way #111499 was implemented is not compatible with the new bottom panel. Not all bottom docks are children of the bottom panel, and also EditorDocks are not being added to
bottom_dockslist, so the code required some changes. The offsets are now stored in a Dictionary, so layout saving is no longer dependent on what dock happens to be at the bottom.#112616 is fixed by adding a default Audio size to the default layout and loading it on initial launch (similar to #113232 in its original form).