Skip to content

Add the ability to toggle the dock heights from being individual to unified#113548

Closed
ghost wants to merge 13 commits into
masterfrom
unknown repository
Closed

Add the ability to toggle the dock heights from being individual to unified#113548
ghost wants to merge 13 commits into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 4, 2025

2025-12-04.02-48-03.mp4

This restores the original tab height functionality while keeping the new code for individual tab heights available for people that want that.

@ghost ghost requested review from a team as code owners December 4, 2025 07:50
@ghost ghost self-requested a review December 4, 2025 07:50
@arkology
Copy link
Copy Markdown
Contributor

arkology commented Dec 4, 2025

At 0:21-0:23 height is still individual when you switch to output🙃

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

At 0:21-0:23 height is still individual when you switch to output🙃

Without adding in another notification to the bottom dock, I am not sure if this is possible to change. It only becomes unified after the first time you change a dock height.

@ghost ghost self-requested a review as a code owner December 4, 2025 08:47
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

2025-12-04.03-47-26.mp4

I added in a new function to handle immediately switching to the unified tab mode whenever the editor setting is changed.

Comment thread editor/editor_node.cpp Outdated
Comment thread editor/editor_node.h Outdated
Comment thread editor/gui/editor_bottom_panel.h Outdated
Comment thread editor/gui/editor_bottom_panel.cpp Outdated
@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Dec 4, 2025

This breaks the default size of Audio dock (you can test by deleting editor_layout.cfg):
image
Either the new setting should be enabled by default or you need to fix it somehow.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

This breaks the default size of Audio dock (you can test by deleting editor_layout.cfg): image Either the new setting should be enabled by default or you need to fix it somehow.

The current 4.6-dev5 version of Godot doesn't respect the default audio panel size after the first click off it from what I just tested. I am not sure what this means exactly.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

2025-12-04.14-39-46.mp4

Proof in 4.6dev5 that the default audio panel size is also broken if the intended behavior is to introduce a custom minimum size only for the audio panel.

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Dec 4, 2025

Looks like a bug.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

What is the intended behavior and where is the default audio bus panel size stored? I can add the fix while I'm working on the changes suggested.

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Dec 4, 2025

Wait, I just noticed the version. This bug is already fixed on master.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

Can you link the commit that fixes it? I'm working off master and I still see the bug.

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Dec 4, 2025

#113241
Are you following the same steps as in the video? I can't reproduce it.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

2025-12-04.16-19-40.mp4

The current commit defaults to the minimum audio bus size which I think is a user-friendly way to manage that. If the user decides to resize the panel after that point, then that is their choice and should be respected (in my opinion).

Whenever the state of the tab height toggle is changed, the current tab height is propagated to all other tabs. So, if the user is in the unified mode and switches to individual, all tabs are reset to the unified height and then the user can customize from there. Likewise, whenever the user switches from the individual mode to the unified mode, all the tabs are reset to the current tab height and the user can customize from there.

This seems like the most intuitive way to handle this from a user expectation standpoint.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

#113241 Are you following the same steps as in the video? I can't reproduce it.

I was syncing the wrong branch.

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 4, 2025

In a separate pull request after this I can add an audio bus minimum size editor setting. It seems a little off topic for this pull request to try and address that here. In all of the other places in the editor it appears like it's a hard coded value to -450.

@ghost ghost requested a review from AThousandShips December 5, 2025 03:09
@ghost ghost self-requested a review as a code owner December 9, 2025 16:54
@ghost ghost force-pushed the unify_bottom_dock_size_optional branch from 1c63a35 to 1b6d5f0 Compare December 9, 2025 17:00
@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 9, 2025

I am struggling to figure out the interactive rebase to squash all my commits.

@ghost ghost closed this Dec 12, 2025
@ghost ghost deleted the unify_bottom_dock_size_optional branch December 12, 2025 00:53
@AThousandShips AThousandShips removed this from the 4.x milestone Dec 12, 2025
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants