Skip to content

Keep the bottom panel size separate.#111499

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
DexterFstone:Keep-the-bottom-panel-size-separate
Nov 12, 2025
Merged

Keep the bottom panel size separate.#111499
Repiteo merged 1 commit into
godotengine:masterfrom
DexterFstone:Keep-the-bottom-panel-size-separate

Conversation

@DexterFstone
Copy link
Copy Markdown
Contributor

@DexterFstone DexterFstone commented Oct 11, 2025

close godotengine/godot-proposals#13359

2025-10-10.22-05-52.mp4

@arkology
Copy link
Copy Markdown
Contributor

IMO this should be editor setting.

@sockeye-d
Copy link
Copy Markdown
Contributor

Can this be persisted across sessions?

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Nov 11, 2025

Needs rebase.

And yeah, it would be nice to persist the value in editor layout. Shouldn't be difficult to add.

@DexterFstone
Copy link
Copy Markdown
Contributor Author

Nothing left of previous codes 😂

Comment thread editor/gui/editor_bottom_panel.h Outdated
Comment thread editor/gui/editor_bottom_panel.cpp Outdated
@DexterFstone DexterFstone force-pushed the Keep-the-bottom-panel-size-separate branch from ba67908 to b6cd20d Compare November 11, 2025 19:51
@DexterFstone
Copy link
Copy Markdown
Contributor Author

rebased and rewritten

@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Nov 11, 2025

Seems like saving center_split_offset is no longer needed, because tab offset + current tab is effectively the same.

@DexterFstone DexterFstone force-pushed the Keep-the-bottom-panel-size-separate branch from b6cd20d to cd0bd81 Compare November 11, 2025 21:18
@KoBeWi
Copy link
Copy Markdown
Member

KoBeWi commented Nov 11, 2025

You should also remove the loading code for center_split_offset 🙃

Comment thread editor/editor_node.cpp
@DexterFstone DexterFstone force-pushed the Keep-the-bottom-panel-size-separate branch 2 times, most recently from 8d52710 to 38cd757 Compare November 11, 2025 21:40
@DexterFstone
Copy link
Copy Markdown
Contributor Author

You should also remove the loading code for center_split_offset 🙃

Sorry, it's 1 AM, I'm editing in sleep 😂

Comment thread editor/editor_node.cpp
@DexterFstone DexterFstone force-pushed the Keep-the-bottom-panel-size-separate branch from 38cd757 to cd943d1 Compare November 11, 2025 22:20
Copy link
Copy Markdown
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.
This will help with #26392 and #112616

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Nov 11, 2025
@Repiteo Repiteo merged commit 78c3a07 into godotengine:master Nov 12, 2025
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Nov 12, 2025

Thanks!

@ghost
Copy link
Copy Markdown

ghost commented Dec 4, 2025

When testing the new dev builds this change has completely destroyed my expectations between panels and leads to me spending a lot of unneeded time resizing the bottom dock.

I feel this is a subversion of how users would expect tabs within a container to function.

Look to the way blender handles the different panels. Changing the content of a panel does not resize the panel. The user has already decided how large that panel is and the content is not the deciding factor. It's like if I changed the timeline on the bottom of the screen to the graph editor and suddenly it changed my entire window layout. Godot itself does not handle tabs in this way anywhere else in the engine. Switching between the scene layout and import settings does not resize the entire left column of my screen.

At the very least there should be a toggle somewhere in the editor settings to unify all the dock heights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep the bottom panel size separate.

6 participants