Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGL: Handle 0 exponent in float/half conversion #72914

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

JonqsGames
Copy link
Contributor

@JonqsGames JonqsGames commented Feb 8, 2023

Fixes #72882 , Fixes #66462 , Fixes #66459
Supersedes #72908 and #72329

Simpler solution only checking for 0 (or too small) exponent

bugsquad edit: Fixes #71731

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I tested locally as well and confirm it fixes the bugs listed.

@clayjohn
Copy link
Member

clayjohn commented Feb 8, 2023

Likely also fixes #71731

@akien-mga akien-mga merged commit 913a65c into godotengine:master Feb 9, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment