Update Tf2CriticalHitsPlugin for FFXIV 7.01 #4053
Conversation
|
bleatbot, approve |
Outdated attemptTake care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it! The average merge time for plugin updates is currently 5 hours.
Show log - Review |
|
If I'm reading this right, it seems the build failure may be caused by the existence of the submodule? If so, should I just fold the files from the submodule directly into the plugin? Edit: I think there's a possibility that this error was this: goatcorp/Plogon#61 |
|
bleatbot, rebuild |
Outdated attemptTake care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
Show log - Review |
Head branch was pushed to by a user without write access
|
Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
Show log - Review |
bleatbot
added
size-small
|
Yeah, looks like the git command in the csproj was the problem. |
|
Congratulations on adopting a plugin and making your first contribution to the ecosystem! As a first-time contributor, if you're in the |
|
@philpax Thanks! I'll take you up on that offer for the dev channels -- I'm @trash.cat on Discord. |
This is a request to adopt the Tf2CriticalHitsPlugin, as the original author (Berna) has decided to stop development. I don't intend to do feature development, but at the very least wanted to get this plugin working on Dawntrail.
Berna's message on Discord regarding stopping development and leaving their plugins up for adoption: https://discord.com/channels/581875019861328007/1069307522269319178/1259198126376488960
Berna's message on GitHub in response to my request to have the plugin be adopted: Berna-L/ffxiv-tf2-crit-plugin#7 (comment)
The bulk of the changes required for the update were compatibility changes for API 10. There are also a few smaller changes to how certain sound logic is handled (using FFXIVClientStructs for built-in sound playing instead of doing it in-house). I've done a fair amount of testing to confirm the behavior works as expected for both the crit sound effects, as well as the Countdown Jams feature, though admittedly, it's not 100% comprehensive.
Additionally, I've elected to keep Berna as the author, as I only intend to keep this plugin compatible with FFXIV/Dalamud updates. If this needs to change, please let me know.