Congratulations 1.3.0.0 #4085
Merged
Congratulations 1.3.0.0 #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outdated attempt
Show log - Review |
|
Hi! You need to be in the |
auto-merge was automatically disabled
July 20, 2024 08:13
Head branch was pushed to by a user without write access
|
Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
Show log - Review |
|
Forgot about that, my bad! |
philpax
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a request to adopt the Congratulations plugin, as the original author (Berna) has decided to stop development. I don't intend to do feature development, but at the very least wanted to get this plugin working on Dawntrail.
(This is another plugin from Berna that I am adopting, the first one being the Tf2CriticalHitsPlugin)
Berna's message on Discord regarding stopping development and leaving their plugins up for adoption: https://discord.com/channels/581875019861328007/1069307522269319178/1259198126376488960
Berna's message on GitHub in response to my request to have the plugin be adopted: Berna-L/ffxiv-tf2-crit-plugin#7 (comment)
Additionally, like before, I've elected to keep Berna as the author, as I only intend to keep this plugin compatible with FFXIV/Dalamud updates. If this needs to change, please let me know.