Repository navigation
fix(server): ComputerUseLeases.ts fits the code budget again - #1890
Merged
Merged
Conversation
This was referenced Oct 27, 2026
Merged
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComputerUseLeases.ts reached 1002 lines on dev, so the code-budget lint breaks CI for every branch based on it.
Move the live grant and grant-state queries, with their existing error class, into ComputerUseLeaseQueries.ts. The service is now 942 lines; its exports, SQL, tracing, and behavior stay the same. The budget baseline is unchanged.
Verification (all exit 0):
vp test run apps/server/src/cua: 930 passed, 2 existing skips (Computer use private mode is switched off; re-enable with a scoped unknown-focus rule #1695).lockf -k /tmp/goat-heavy-check.lock vp run check:changed: format, lint, knip, GraphQL and affected typechecks passed; 620 selected tests passed, 2 existing skips and 1 existing todo.node scripts/goat-rename.ts --check: no residue.vp lint apps/server/src/cua(the repo equivalent of oxlint): no errors or code-budget findings.NOT RUN: full repository suites, build, and real-client smoke tests; this refactor has no visible behavior change.
Model: gpt-6.1-sol via GOAT delegated task (Codex harness)