Repository navigation
fix(clients): restore token counts and neutral stopped runs (chase 261028 B22) - #1932
Merged
Merged
Conversation
Preserve GOAT's existing compact control labels and styling while showing the history token count in the redesign as well as the classic design. Upstream: b333c175baf9d396e3161f7f1d0f2999a487e883 (#25818)
Use GOAT's existing stop glyphs and neutral lifecycle row styling for intentional interruptions on web, desktop, and mobile. Keep provider failures and notices distinct. Move the mobile icon mappings into focused modules to keep the existing files within their code budgets. Add regression coverage for stop semantics, retained interruption detail, and actual provider failures. Local suites are intentionally unrun per the task's override. Upstream: f3b058cd6a737e51894bc265927560b23742f0f0 (#25830)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOAT's redesigned compact toggle hides the history token count, and intentionally interrupted runs still use error or warning visuals. This restores the count in both composer designs and presents interruption as a neutral stop on web, desktop, and mobile.
Upstream commits
b333c175baf9d396e3161f7f1d0f2999a487e883f3b058cd6a737e51894bc265927560b23742f0f0GOAT adjustments
96fc7b9551.SquareIconon web/desktop and the existingstop.fillnative symbol on mobile. The interruption message remains available.threadActivity.tsandthread-work-log.tsxwere exactly at their code-budget baselines; both existing files shrink. No budget baseline changes.Rename residue
git show <sha> --format= | rg '^\+.*\b[Tt]3'found no added T3 names in either upstream commit (zero matches for each). No rename rules, exclusions, or retained-name exceptions are needed.node scripts/goat-rename.ts --checkexited 0:0 lines with T3 residue in 0 files, 0 dropped paths.Verification
vp fmton all nine changed files across the two commits: exit 0.git diff --check origin/dev...HEAD: exit 0.node scripts/goat-rename.ts --check: exit 0.test-goat-app:preview.statusreturnedavailable: false. No dev server was started and no before/after captures were produced.NOT RUN: local suites (
vp test run apps/web/src/components/chat/V2LifecycleRow.logic.test.ts apps/mobile/src/lib/threadActivity*.test.ts, Vitest, and server suites);vp run check:changed;vp run typecheck; all lockf-wrapped test/check/typecheck runs; pre-commitvp staged(disabled to honor the override); real-client web/desktop before/after captures (Browser panel unavailable); native mobile smoke verification. Regression red/green is unverified locally. CI results are not awaited. The known origin/devComputerUseLeases.tscode-budget issue (#1890) is outside this change.Model: gpt-6.1-sol via GOAT delegated task (Codex harness)