Repository navigation
fix(web): onboarding import finishes when the project never arrives (chase 261028 B35) - #1931
Merged
Merged
Conversation
…rives (#25805) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 2202787df02471c5177f95174bd4ef6bf95b785a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding import can remain stuck when the server accepts a project but it never reaches the client's project store. This change uses the existing bounded project wait, completes setup without a landing project after the wait fails, and releases the import step for retry when saving completion fails.
2202787df02471c5177f95174bd4ef6bf95b785aGOAT adjustments:
isGoatConnectEnabledmock alongside upstream's regression test.@goat/*imports. The existingwaitForProjecthelper defaults to 10 seconds.Not taken: none.
Rename residue:
git show 2202787df0 | rg '^\+.*\b[Tt]3': no added T3 names (rg exit 1 for no matches). No new rename rules or keep exceptions needed.node scripts/goat-rename.ts --check: exit 0;0 lines with T3 residue in 0 files, 0 dropped paths.Verification:
vp fmt apps/web/src/components/onboarding/WelcomeWizard.tsx apps/web/src/components/onboarding/WelcomeWizard.import.browser.test.tsx: exit 0, two files formatted; the commit hook also runs formatting only.git diff --cached --checkandgit diff origin/dev --check: exit 0.preview.statusreturnedavailable: false. No captures are available.ComputerUseLeases.tscode budget tracked by fix(server): ComputerUseLeases.ts fits the code budget again #1890; this PR does not change it.NOT RUN:
vp test run apps/web/src/components/onboarding/WelcomeWizard.import.browser.test.tsxor any adjacent/local test suites; regression red/green execution;vp run check:changed;vp run typecheck; vitest; lockf-wrapped test/check/typecheck runs; standalone lint/build checks (local suites and non-cheap checks prohibited by the task override). Real-client smoke and before/after captures were not run because the Browser panel is unavailable. CI results have not been awaited.Model: gpt-6.1-sol via GOAT delegated task (Codex harness)