Skip to content

fix(web): onboarding import finishes when the project never arrives (chase 261028 B35) - #1931

Merged
lidge-jun merged 1 commit into
devfrom
chase/261028-b35-onboarding-import
Oct 27, 2026
Merged

lidge-jun merged 1 commit into
devfrom
chase/261028-b35-onboarding-import

Conversation

@lidge-jun

Copy link
Copy Markdown
Contributor

Onboarding import can remain stuck when the server accepts a project but it never reaches the client's project store. This change uses the existing bounded project wait, completes setup without a landing project after the wait fails, and releases the import step for retry when saving completion fails.

Upstream commit Upstream PR Decision What GOAT got
2202787df02471c5177f95174bd4ef6bf95b785a pingdotgg/t3code#25805 take Bounded import completion with an unmount generation guard and a missing-project/completion-retry regression test.

GOAT adjustments:

  • Resolved the test-file conflict by retaining GOAT's isGoatConnectEnabled mock alongside upstream's regression test.
  • Kept GOAT's existing onboarding layout and @goat/* imports. The existing waitForProject helper defaults to 10 seconds.
  • Applies to the shared web/desktop onboarding flow, including remote environments. No mobile, provider, RPC, or contract changes.
  • Ran the required rename application; reverted its unrelated repository-fixture rewrites so this PR changes only the two onboarding files.

Not taken: none.

Rename residue:

  • git show 2202787df0 | rg '^\+.*\b[Tt]3': no added T3 names (rg exit 1 for no matches). No new rename rules or keep exceptions needed.
  • node scripts/goat-rename.ts --check: exit 0; 0 lines with T3 residue in 0 files, 0 dropped paths.

Verification:

  • vp fmt apps/web/src/components/onboarding/WelcomeWizard.tsx apps/web/src/components/onboarding/WelcomeWizard.import.browser.test.tsx: exit 0, two files formatted; the commit hook also runs formatting only.
  • git diff --cached --check and git diff origin/dev --check: exit 0.
  • Reviewed the two-file diff and checked added lines for private workspace paths, credentials, and pairing URLs; no matches.
  • Browser panel: preview.status returned available: false. No captures are available.
  • Verification is delegated to goat-ci on this PR per the task override; results are not awaited. Known base issue: goat-check may report the unrelated ComputerUseLeases.ts code budget tracked by fix(server): ComputerUseLeases.ts fits the code budget again #1890; this PR does not change it.

NOT RUN: vp test run apps/web/src/components/onboarding/WelcomeWizard.import.browser.test.tsx or any adjacent/local test suites; regression red/green execution; vp run check:changed; vp run typecheck; vitest; lockf-wrapped test/check/typecheck runs; standalone lint/build checks (local suites and non-cheap checks prohibited by the task override). Real-client smoke and before/after captures were not run because the Browser panel is unavailable. CI results have not been awaited.

Model: gpt-6.1-sol via GOAT delegated task (Codex harness)

…rives (#25805)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 2202787df02471c5177f95174bd4ef6bf95b785a)
@lidge-jun
lidge-jun merged commit 74b4a8d into dev Oct 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants